Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: chrome/common/extensions/manifest.cc

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest.cc
===================================================================
--- chrome/common/extensions/manifest.cc (revision 114019)
+++ chrome/common/extensions/manifest.cc (working copy)
@@ -112,7 +112,7 @@
Manifest::Manifest(DictionaryValue* value) : value_(value) {}
Manifest::~Manifest() {}
-bool Manifest::ValidateManifest(std::string* error) const {
+bool Manifest::ValidateManifest(string16* error) const {
Restrictions restrictions = g_restrictions.Get();
Type type = GetType();
@@ -127,7 +127,7 @@
}
if (!restrictions.CanAccessKey(*key, type)) {
- *error = ExtensionErrorUtils::FormatErrorMessage(
+ *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
errors::kFeatureNotAllowed, *key);
return false;
}

Powered by Google App Engine
This is Rietveld 408576698