chrome/browser/extensions/sandboxed_extension_unpacker.h - Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.h

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/sandboxed_extension_unpacker.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/sandboxed_extension_unpacker.h

===================================================================

--- chrome/browser/extensions/sandboxed_extension_unpacker.h (revision 114019)

+++ chrome/browser/extensions/sandboxed_extension_unpacker.h (working copy)

@@ -38,7 +38,7 @@

const FilePath& extension_root,

const base::DictionaryValue* original_manifest,

const Extension* extension) = 0;

- virtual void OnUnpackFailure(const std::string& error) = 0;

+ virtual void OnUnpackFailure(const string16& error) = 0;

protected:

friend class base::RefCountedThreadSafe<SandboxedExtensionUnpackerClient>;

@@ -199,9 +199,9 @@

// IPC message handlers.

void OnUnpackExtensionSucceeded(const base::DictionaryValue& manifest);

- void OnUnpackExtensionFailed(const std::string& error_message);

+ void OnUnpackExtensionFailed(const string16& error_message);

- void ReportFailure(FailureReason reason, const std::string& message);

+ void ReportFailure(FailureReason reason, const string16& message);

void ReportSuccess(const base::DictionaryValue& original_manifest);

// Overwrites original manifest with safe result from utility process.