chrome/browser/extensions/crx_installer.h - Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 8890086: Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/convert_user_script_unittest.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | chrome/common/extensions/extension.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/crx_installer.h

===================================================================

--- chrome/browser/extensions/crx_installer.h (revision 114019)

+++ chrome/browser/extensions/crx_installer.h (working copy)

@@ -198,10 +198,10 @@

// Called after OnUnpackSuccess as a last check to see whether the install

// should complete.

- bool AllowInstall(const Extension* extension, std::string* error);

+ bool AllowInstall(const Extension* extension, string16* error);

// SandboxedExtensionUnpackerClient

- virtual void OnUnpackFailure(const std::string& error_message) OVERRIDE;

+ virtual void OnUnpackFailure(const string16& error_message) OVERRIDE;

virtual void OnUnpackSuccess(const FilePath& temp_dir,

const FilePath& extension_dir,

const base::DictionaryValue* original_manifest,

@@ -220,8 +220,8 @@

void CompleteInstall();

// Result reporting.

- void ReportFailureFromFileThread(const std::string& error);

- void ReportFailureFromUIThread(const std::string& error);

+ void ReportFailureFromFileThread(const string16& error);

+ void ReportFailureFromUIThread(const string16& error);

void ReportSuccessFromFileThread();

void ReportSuccessFromUIThread();

void NotifyCrxInstallComplete(const Extension* extension);