Issue 71980: Extensions code should use UTF-16 for user-visible Unicode strings

chrome/browser/extensions/webstore_installer.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_installer.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
+#include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_util.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension.h"
@@ skipping 110 matching lines @@
         ReportSuccess();
       break;
     }
 
     case chrome::NOTIFICATION_EXTENSION_INSTALL_ERROR: {
       CrxInstaller* crx_installer = content::Source<CrxInstaller>(source).ptr();
       CHECK(crx_installer);
       if (!profile_->IsSameProfile(crx_installer->profile()))
         return;
 
-      const std::string* error =
-          content::Details<const std::string>(details).ptr();
+      // TODO(rdevlin.cronin): Continue removing std::string errors and
+      // replacing with string16
+      const string16* error = content::Details<const string16>(details).ptr();
+      const std::string utf8_error = UTF16ToUTF8(*error);
       if (download_url_ == crx_installer->original_download_url())
-        ReportFailure(*error);
+        ReportFailure(utf8_error);
       break;
     }
 
     default:
       NOTREACHED();
   }
 }
 
 void WebstoreInstaller::StartDownload(FilePath file) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ skipping 23 matching lines @@
 
   Release();  // Balanced in Start().
 }
 
 void WebstoreInstaller::ReportSuccess() {
   if (delegate_)
     delegate_->OnExtensionInstallSuccess(id_);
 
   Release();  // Balanced in Start().
 }