Index: Source/WebCore/ChangeLog |
=================================================================== |
--- Source/WebCore/ChangeLog (revision 102688) |
+++ Source/WebCore/ChangeLog (working copy) |
@@ -1,3 +1,1886 @@ |
+2011-12-12 Shawn Singh <shawnsingh@chromium.org> |
+ |
+ [chromium] Remove assumption that empty surface is always at end of list |
+ https://bugs.webkit.org/show_bug.cgi?id=74037 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Test case added to CCLayerTreeHostCommonTest.cpp, which reproduces |
+ a crash reported in http://code.google.com/p/chromium/issues/detail?id=106734 |
+ |
+ This patch fixes the crash in a less risky way to be merged into |
+ m17, but the root of the issue needs to be addressed in a |
+ follow-up patch. |
+ |
+ * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: |
+ (WebCore::calculateDrawTransformsAndVisibilityInternal): |
+ |
+2011-12-12 Simon Fraser <simon.fraser@apple.com> |
+ |
+ Share code that checks for matching sets of transform operations |
+ https://bugs.webkit.org/show_bug.cgi?id=74265 |
+ |
+ Reviewed by Dan Bernstein. |
+ |
+ Add TransformOperations::operationsMatch() and call it from the |
+ three places that used this same code. |
+ |
+ Tested by existing tests. |
+ |
+ * page/animation/ImplicitAnimation.cpp: |
+ (WebCore::ImplicitAnimation::validateTransformFunctionList): |
+ * page/animation/KeyframeAnimation.cpp: |
+ (WebCore::KeyframeAnimation::validateTransformFunctionList): |
+ * platform/graphics/GraphicsLayer.cpp: |
+ (WebCore::GraphicsLayer::fetchTransformOperationList): |
+ * platform/graphics/transforms/TransformOperations.cpp: |
+ (WebCore::TransformOperations::operationsMatch): |
+ * platform/graphics/transforms/TransformOperations.h: |
+ |
+2011-12-12 Antti Koivisto <antti@apple.com> |
+ |
+ Cache visited link hash |
+ https://bugs.webkit.org/show_bug.cgi?id=74095 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Visited link hash is relatively expensive to compute. We can cache it for anchor elements |
+ with minimal relative memory cost for faster style resolve. |
+ |
+ On my machine this speeds up style matching on full HTML spec by ~100ms or ~1% of the total |
+ CPU usage. It makes link elements 8 bytes larger, a relatively minor increase to their overall size. |
+ |
+ Invalidate the hashes on base URL for completeness sake (lack of style invalidation means |
+ that this scenario is not properly supported currently). |
+ |
+ Covered by existing tests. No specific test for visited hash invalidation on dynamic base URL |
+ change as the effect is not testable due to lack of style invalidation. |
+ |
+ * css/SelectorChecker.cpp: |
+ (WebCore::SelectorChecker::determineLinkStateSlowCase): |
+ (WebCore::SelectorChecker::visitedStateChanged): |
+ * html/Document.cpp: |
+ * html/HTMLAnchorElement.cpp: |
+ (WebCore::HTMLAnchorElement::HTMLAnchorElement): |
+ (WebCore::HTMLAnchorElement::parseMappedAttribute): |
+ * html/HTMLAnchorElement.h: |
+ (WebCore::HTMLAnchorElement::visitedLinkHash): |
+ |
+2011-12-12 Martin Robinson <mrobinson@igalia.com> |
+ |
+ [GTK] gtk_widget_size_allocate for plugin widgets should happen in the WebView size-allocate method |
+ https://bugs.webkit.org/show_bug.cgi?id=72805 |
+ |
+ Reviewed by Gustavo Noronha Silva. |
+ |
+ No new tests. This is only a performance tweak. |
+ |
+ Instead of immediately calling gtk_widget_size during painting, defer |
+ this until the size-allocate method of the WebView. |
+ |
+ * plugins/gtk/PluginViewGtk.cpp: |
+ (WebCore::PluginView::updateWidgetAllocationAndClip): Instead of immediately changing |
+ the widget allocation, just record it in a GObject data attachment. |
+ |
+2011-12-12 Nate Chapin <japhet@chromium.org> |
+ |
+ A SubresourceLoader in the middle of revalidating |
+ a resource should be treated as finishing (similar to |
+ didFinishLoading and didFail) to ensure that willCancel() |
+ doesn't declare the revalidation as having failed reentrantly. |
+ https://bugs.webkit.org/show_bug.cgi?id=72762 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: http/tests/cache/cancel-during-revalidation-succeeded.html |
+ |
+ * loader/SubresourceLoader.cpp: |
+ (WebCore::SubresourceLoader::didReceiveResponse): |
+ |
+2011-12-12 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Upstream 3 files into WebCore/platform/blackberry |
+ https://bugs.webkit.org/show_bug.cgi?id=74275 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Initial upstream, no new tests. |
+ |
+ * platform/blackberry/ContextMenuBlackBerry.cpp: Added. |
+ * platform/blackberry/ContextMenuItemBlackBerry.cpp: Added. |
+ * platform/blackberry/TemporaryLinkStubs.cpp: Added. |
+ |
+2011-12-12 Pierre Rossi <pierre.rossi@gmail.com> |
+ |
+ [Qt] Rendering issues with sliders and QStyle |
+ https://bugs.webkit.org/show_bug.cgi?id=73921 |
+ |
+ With QStyle's origins being deeply rooted with widgets, |
+ several styles make wrong assumptions, leading to sliders |
+ not being painted properly in WebKit. We can solve a lot |
+ of problems by systematically translating the painter to |
+ the top left corner of the render object. |
+ |
+ Reviewed by Simon Hausmann. |
+ |
+ No new tests. The Qt tests are ran with the Windows |
+ style, this fixes some quirks affecting other styles. |
+ |
+ * platform/qt/RenderThemeQStyle.cpp: |
+ (WebCore::RenderThemeQStyle::paintSliderTrack): |
+ (WebCore::RenderThemeQStyle::paintSliderThumb): |
+ |
+2011-12-12 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Upstream 5 files into WebCore/platform/blackberry |
+ https://bugs.webkit.org/show_bug.cgi?id=73798 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Main contributors: |
+ Genevieve Mak <gmak@rim.com> |
+ Mike Lattanzio <mlattanzio@rim.com> |
+ George Staikos <gstaikos@rim.com> |
+ |
+ Initial upstream, no new tests. |
+ |
+ * platform/blackberry/PlatformTouchEventBlackBerry.cpp: Added. |
+ (WebCore::PlatformTouchEvent::PlatformTouchEvent): |
+ * platform/blackberry/PlatformTouchPointBlackBerry.cpp: Added. |
+ (WebCore::PlatformTouchPoint::PlatformTouchPoint): |
+ * platform/blackberry/SharedBufferBlackBerry.cpp: Added. |
+ (WebCore::SharedBuffer::createWithContentsOfFile): |
+ * platform/blackberry/SharedTimerBlackBerry.cpp: Added. |
+ (WebCore::SharedTimerBlackBerry::SharedTimerBlackBerry): |
+ (WebCore::SharedTimerBlackBerry::~SharedTimerBlackBerry): |
+ (WebCore::SharedTimerBlackBerry::instance): |
+ (WebCore::SharedTimerBlackBerry::start): |
+ (WebCore::SharedTimerBlackBerry::stop): |
+ (WebCore::setSharedTimerFiredFunction): |
+ (WebCore::setSharedTimerFireInterval): |
+ (WebCore::stopSharedTimer): |
+ * platform/blackberry/SystemTimeBlackBerry.cpp: Added. |
+ (WebCore::userIdleTime): |
+ |
+2011-12-12 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Implement a cache for CSSStyleRule::selectorText() |
+ https://bugs.webkit.org/show_bug.cgi?id=74269 |
+ |
+ This change is geared towards speeding up the CSS selector profiler, |
+ its implementation tracked at https://bugs.webkit.org/show_bug.cgi?id=74004. |
+ Using a proof-of-concept implementation of the profiler, this change reduces |
+ the profiler temporal overhead on PerformanceTests/Parser/html5-full-render.html |
+ roughly by 86% (from ~72 seconds down to ~10 seconds). This change also does not |
+ considerably increase average memory usage, as reading selectorText is a relatively |
+ rare case during normal web browsing. |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ No new tests, as this functionality is covered by existing tests. |
+ |
+ * css/CSSRule.h: |
+ * css/CSSStyleRule.cpp: |
+ (WebCore::CSSStyleRule::~CSSStyleRule): |
+ (WebCore::selectorTextCache): |
+ (WebCore::CSSStyleRule::cleanup): |
+ (WebCore::CSSStyleRule::generateSelectorText): |
+ (WebCore::CSSStyleRule::selectorText): |
+ (WebCore::CSSStyleRule::setSelectorText): |
+ * css/CSSStyleRule.h: |
+ |
+2011-12-12 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Web Inspector: [Styles] Modified selector text needs sanitization |
+ https://bugs.webkit.org/show_bug.cgi?id=74291 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * inspector/front-end/StylesSidebarPane.js: |
+ |
+2011-12-12 Renata Hodovan <reni@webkit.org> |
+ |
+ Fulfill FIXME in HTMLLinkElement.h. |
+ https://bugs.webkit.org/show_bug.cgi?id=74278 |
+ |
+ Rename HTMLLinkElement::isLoading() to isStyleSheetLoading(). |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ No new tests because the functionality remains the same. |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::recalcStyleSelector): |
+ * html/HTMLLinkElement.cpp: |
+ (WebCore::HTMLLinkElement::setDisabledState): |
+ (WebCore::HTMLLinkElement::isStyleSheetLoading): |
+ (WebCore::HTMLLinkElement::sheetLoaded): |
+ * html/HTMLLinkElement.h: |
+ |
+2011-11-25 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ WebKit does not enumerate over CSS properties in HTMLElement.style |
+ https://bugs.webkit.org/show_bug.cgi?id=23946 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ This change generates a list of JavaScript mirrors of the CSS properties and allows to enumerate them |
+ using the "in" operator on the CSSStyleDeclaration object. |
+ |
+ Test: fast/css/style-enumerate-properties.html |
+ |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ (WebCore::JSCSSStyleDeclaration::getOwnPropertyNames): Added. |
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator): Added. |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyQuery): Added. |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): A small drive-by optimization (local initialization moved down). |
+ * css/CSSStyleDeclaration.idl: Use a custom property enumerator. |
+ * css/makeprop.pl: Add a function to convert CSS property names into JS ones. |
+ |
+2011-12-12 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ Unreviewed, build fix. |
+ |
+ Revert r102570 which broke SnowLeopard builders. |
+ |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): |
+ * css/CSSStyleDeclaration.idl: |
+ * css/makeprop.pl: |
+ |
+2011-12-12 Ilya Tikhonovsky <loislo@chromium.org> |
+ |
+ Web Inspector: chromium: UI: Detailed Heap snapshot shows too many objects' hidden properties. |
+ https://bugs.webkit.org/show_bug.cgi?id=74289 |
+ |
+ WebCore objects have many hidden properties. |
+ The Detailed Heap shapshot view shows all these props for a selected object. |
+ The result view looks too heavy and users usually failed to find a useful information about the object. |
+ Looks like such ability is unnecessary in the most cases. |
+ I'd like to introduce a configurable property that will show/hide these props from the view. |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ * English.lproj/localizedStrings.js: |
+ * inspector/front-end/DetailedHeapshotGridNodes.js: |
+ * inspector/front-end/DetailedHeapshotView.js: |
+ * inspector/front-end/HeapSnapshotProxy.js: |
+ (WebInspector.HeapSnapshotProxy.prototype.createPathFinder): |
+ * inspector/front-end/SettingsScreen.js: |
+ (WebInspector.SettingsScreen): |
+ |
+2011-12-12 Kentaro Hara <haraken@chromium.org> |
+ |
+ Unreviewed, rolling out r102556. |
+ http://trac.webkit.org/changeset/102556 |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ clobber build failure |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): |
+ * WebCore.gypi: |
+ * bindings/scripts/generate-bindings.pl: |
+ * page/DOMWindow.idl: |
+ * webaudio/DOMWindowWebAudio.idl: Removed. |
+ |
+2011-12-12 Kentaro Hara <haraken@chromium.org> |
+ |
+ Unreviewed, rolling out r102558. |
+ http://trac.webkit.org/changeset/102558 |
+ https://bugs.webkit.org/show_bug.cgi?id=74160 |
+ |
+ clobber build failure |
+ |
+ * WebCore.gypi: |
+ * page/DOMWindow.idl: |
+ * websockets/DOMWindowWebSocket.idl: Removed. |
+ |
+2011-11-25 Alexander Pavlov <apavlov@chromium.org> |
+ |
+ WebKit does not enumerate over CSS properties in HTMLElement.style |
+ https://bugs.webkit.org/show_bug.cgi?id=23946 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ This change generates a list of JavaScript mirrors of the CSS properties and allows to enumerate them |
+ using the "in" operator on the CSSStyleDeclaration object. |
+ |
+ Test: fast/css/style-enumerate-properties.html |
+ |
+ * bindings/js/JSCSSStyleDeclarationCustom.cpp: |
+ (WebCore::JSCSSStyleDeclaration::getOwnPropertyNames): Added. |
+ * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator): Added. |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyQuery): Added. |
+ (WebCore::V8CSSStyleDeclaration::namedPropertyGetter): A small drive-by optimization (local initialization moved down). |
+ * css/CSSStyleDeclaration.idl: Use a custom property enumerator. |
+ * css/makeprop.pl: Add a function to convert CSS property names into JS ones, and a string comparator. |
+ |
+2011-12-09 Yury Semikhatsky <yurys@chromium.org> |
+ |
+ Web Inspector: provide per Document Node count statistics |
+ https://bugs.webkit.org/show_bug.cgi?id=74100 |
+ |
+ Memory agent now returns counters for nodes with given names. For each |
+ object group root user will see total number of its descendtants and per |
+ tag name counts. |
+ |
+ This patch also moves generic CounterVisitor code out of V8 bindings. It |
+ may well be used with both JS engines. |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/ScriptProfiler.h: |
+ (WebCore::ScriptProfiler::visitJSDOMWrappers): |
+ * bindings/v8/ScriptProfiler.cpp: |
+ (WebCore::ScriptProfiler::visitJSDOMWrappers): |
+ * bindings/v8/ScriptProfiler.h: |
+ * inspector/DOMWrapperVisitor.h: Added. |
+ (WebCore::DOMWrapperVisitor::~DOMWrapperVisitor): |
+ * inspector/Inspector.json: |
+ * inspector/InspectorMemoryAgent.cpp: |
+ (WebCore::InspectorMemoryAgent::getDOMNodeCount): |
+ * inspector/InspectorMemoryAgent.h: |
+ |
+2011-12-12 Noel Gordon <noel.gordon@gmail.com> |
+ |
+ WebPImageDecoder: Increase image/webp decoding performance 10-20% |
+ https://bugs.webkit.org/show_bug.cgi?id=74263 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Avoid copying data from the RGB buffer of decoded image output to the |
+ backing pixel store. That is slow - costs 10% of the overall decoding |
+ time at libwebp 0.1.2, and 20% at libwebp 0.1.3. |
+ |
+ Instead, instruct the decoder to write the decoded pixels directly to |
+ the backing pixel store. |
+ |
+ No new tests. Covered by existing tests. No progressive decoding test |
+ exists in DRT, see https://bugs.webkit.org/show_bug.cgi?id=74062 |
+ |
+ * platform/image-decoders/webp/WEBPImageDecoder.cpp: |
+ (outputMode): Define output pixel format. On little-endian machines, |
+ output BGRA pixels to the backing store, for example. |
+ (WebCore::WEBPImageDecoder::WEBPImageDecoder): |
+ (WebCore::WEBPImageDecoder::decode): |
+ * platform/image-decoders/webp/WEBPImageDecoder.h: |
+ |
+2011-12-11 Zoltan Herczeg <zherczeg@webkit.org> |
+ |
+ Add new CSS nth-children parsing tests |
+ https://bugs.webkit.org/show_bug.cgi?id=74178 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: fast/css/parsing-css-nth-child.html |
+ |
+ * css/CSSParser.cpp: |
+ (WebCore::isValidNthToken): Add "-n" to the possible identifiers. |
+ |
+2011-12-11 Kentaro Hara <haraken@chromium.org> |
+ |
+ Use [Supplemental] IDL in WebSocket |
+ https://bugs.webkit.org/show_bug.cgi?id=74160 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ By using the [Supplemental] IDL, this patch moves declarations of WebSocket |
+ attributes from DOMWindow.idl to websocket/DOMWindowWebSocket.idl, |
+ which helps make WebSocket a self-contained module. |
+ |
+ No new tests, no change in behavior. |
+ Confirm that http/tests/websocket/* pass. |
+ |
+ * WebCore.gypi: Added DOMWindowWebSocket.idl. |
+ * page/DOMWindow.idl: Added the [Supplemented] IDL to WebSocket-related attributes. This [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL (See bug 73394 for more details). |
+ * websockets/DOMWindowWebSocket.idl: Added. Used the [Supplemental=DOMWindow] IDL. The attributes in this IDL file are treated as if they are described in DOMWindow.idl. |
+ |
+2011-12-11 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Implement webkit-line-grid and webkit-line-grid-snap CSS properties in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=74262 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ No new tests / refactoring only. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
+2011-12-11 Kentaro Hara <haraken@chromium.org> |
+ |
+ Use the [Supplemental] IDL for webaudio attributes in Chromium |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ - Overview: Using the [Supplemental] IDL, this patch moves the attribute |
+ declarations of webaudio from DOMWindow.idl into a new IDL file |
+ webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained |
+ feature (aka a module). |
+ |
+ - This patch changes the build flow of WebCore.gyp as follows: |
+ |
+ Previous build flow: |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl generates .h and .cpp files for $idl; |
+ } |
+ |
+ New build flow (See the discussions in bug 72138 for more details): |
+ resolve-supplemental.pl depends on all IDL files; |
+ resolve-supplemental.pl reads all IDL files; |
+ resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX]; |
+ resolve-supplemental.pl outputs supplemental_dependency.tmp; |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl and supplemental_dependency.tmp; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl reads supplemental_dependency.tmp; |
+ generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl; |
+ } |
+ |
+ - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL |
+ will be removed after build scripts for all platforms support the [Supplemental] IDL. |
+ The motivation for the [Supplemented] IDL is as follows: |
+ |
+ In order to support the [Supplemental] IDL, we need to |
+ (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp |
+ (2) and run generate-bindings.pl with the supplemental_dependency.tmp. |
+ |
+ This build flow requires a change on the following build scripts, |
+ but changing all the build scripts all at once without any regression is too difficult: |
+ |
+ - DerivedSources.make |
+ - DerivedSources.pri |
+ - GNUmakefile.am |
+ - PlatformBlackBerry.cmake |
+ - UseJSC.cmake |
+ - UseV8.cmake |
+ - WebCore.vcproj/MigrateScripts |
+ - WebCore.vcproj/WebCore.vcproj |
+ - bindings/gobject/GNUmakefile.am |
+ - WebCore.gyp/WebCore.gyp |
+ |
+ Thus, we are planning to change the build scripts one by one, which implies that |
+ we need to allow the temporary state in which some build scripts support [Supplemental] IDL |
+ but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented]. |
+ The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental] |
+ in another IDL file somewhere, like this: |
+ |
+ DOMWindowWebAudio.idl: |
+ interface [ |
+ Supplemental=DOMWindow |
+ ] DOMWindowWebAudio { |
+ attribute attr1; |
+ attribute attr2; |
+ }; |
+ |
+ DOMWindow.idl: |
+ interface [ |
+ ] DOMWindow { |
+ attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL |
+ attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL. |
+ attribute attr3; |
+ attribute attr4; |
+ }; |
+ |
+ Assuming these IDL files, this patch implements the following logic in generate-bindings.pl: |
+ |
+ - If a given build script supports the [Supplemental] IDL, |
+ generate-bindings.pl ignores all attributes with the [Supplemented] IDL. |
+ - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL |
+ as normal attributes and instead ignores all attributes with the [Supplemental] IDL |
+ (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL). |
+ |
+ Tests: webaudio/* |
+ |
+ * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above. |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command. |
+ * WebCore.gypi: Added DOMWindowWebAudio.idl. |
+ * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL. |
+ * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL. |
+ * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl. |
+ |
+2011-12-11 Andreas Kling <kling@webkit.org> |
+ |
+ Micro-optimize CSSStyleSelector::findSiblingForStyleSharing(). |
+ <http://webkit.org/b/74261> |
+ |
+ Reviewed by Antti Koivisto. |
+ |
+ Move the isStyledElement() check from canShareStyleWithElement() into the |
+ loop in findSiblingForStyleSharing(), and tighten up the argument/return |
+ types to StyledElement* as appropriate. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::canShareStyleWithElement): |
+ (WebCore::CSSStyleSelector::findSiblingForStyleSharing): |
+ (WebCore::CSSStyleSelector::locateSharedStyle): |
+ * css/CSSStyleSelector.h: |
+ |
+2011-12-11 Shinya Kawanaka <shinyak@google.com> |
+ |
+ Asynchronous path synchronous path of SpellChecker should share the code to mark misspellings. |
+ https://bugs.webkit.org/show_bug.cgi?id=73616 |
+ |
+ Reviewed by Hajime Morita. |
+ |
+ Asynchronous spellchecking path should call the same method for the synchronous spellchecking path |
+ to mark misspellings. |
+ |
+ No new tests. Covered by existing tests. |
+ |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): |
+ (WebCore::Editor::markAndReplaceFor): |
+ Takes SpellCheckRequest object. |
+ * editing/Editor.h: |
+ * editing/SpellChecker.cpp: |
+ (WebCore::SpellChecker::didCheck): |
+ Calls the same method of synchronous spellchecking path. |
+ |
+2011-12-11 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Implement CSS display property in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=73500 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ Refactoring only / no functionality changed. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyDisplay::isValidDisplayValue): |
+ (WebCore::ApplyPropertyDisplay::applyInheritValue): |
+ (WebCore::ApplyPropertyDisplay::applyInitialValue): |
+ (WebCore::ApplyPropertyDisplay::applyValue): |
+ (WebCore::ApplyPropertyDisplay::createHandler): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
+2011-12-11 Geoffrey Garen <ggaren@apple.com> |
+ |
+ Try to fix the Qt build. |
+ |
+ Unreviewed. |
+ |
+ * css/CSSStyleDeclaration.cpp: Maybe an #include will solve our problem? |
+ Someday, compiler error messages will not suck. Today is not that day. |
+ |
+2011-12-11 Luke Macpherson <macpherson@chromium.org> |
+ |
+ Implement CSS resize property in CSSStyleApplyProperty. |
+ https://bugs.webkit.org/show_bug.cgi?id=74162 |
+ |
+ Reviewed by Julien Chaffraix. |
+ |
+ No new tests / refactoring only. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyResize::applyValue): |
+ (WebCore::ApplyPropertyResize::createHandler): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::applyProperty): |
+ |
+2011-12-11 Andreas Kling <kling@webkit.org> |
+ |
+ Move CSSElementStyleDeclaration to its own cpp/h files. |
+ <http://webkit.org/b/74256> |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ CSSElementStyleDeclaration is old enough to move out of CSSMutableStyleDeclaration's |
+ attic and into her own apartment. |
+ |
+ * CMakeLists.txt: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.vcproj/WebCore.vcproj: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSDOMBinding.h: |
+ * css/CSSElementStyleDeclaration.cpp: Added. |
+ (WebCore::CSSElementStyleDeclaration::styleSheet): |
+ * css/CSSElementStyleDeclaration.h: Added. |
+ (WebCore::CSSElementStyleDeclaration::element): |
+ (WebCore::CSSElementStyleDeclaration::setElement): |
+ (WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration): |
+ (WebCore::CSSElementStyleDeclaration::~CSSElementStyleDeclaration): |
+ * css/CSSInlineStyleDeclaration.h: |
+ * css/CSSMutableStyleDeclaration.cpp: |
+ * css/CSSMutableStyleDeclaration.h: |
+ * dom/CSSMappedAttributeDeclaration.h: |
+ |
+2011-12-11 Benjamin Poulain <bpoulain@apple.com> |
+ |
+ Add KillRingNone.cpp to Mac build system |
+ https://bugs.webkit.org/show_bug.cgi?id=74168 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ Add KillRingNone.cpp so it can be used on iOS, but |
+ blacklist the file from the build in order to avoid |
+ conflicts with KillRingMac. |
+ |
+ * Configurations/WebCore.xcconfig: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ |
+2011-12-11 Peter Rybin <peter.rybin@gmail.com> |
+ |
+ Web Inspector: [protocol] alter some type names generated from Inspector.json |
+ https://bugs.webkit.org/show_bug.cgi?id=74247 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Manually-filled map added that contains problem type names and its replacement. |
+ |
+ * inspector/CodeGeneratorInspector.py: |
+ (fix_type_name.Result): |
+ (fix_type_name.Result.output_comment): |
+ (fix_type_name): |
+ (TypeBindings.create_for_named_type_declaration.write_doc): |
+ (TypeBindings.create_for_named_type_declaration.EnumBinding.generate_type_builder): |
+ (TypeBindings.create_for_named_type_declaration.PlainString.generate_type_builder): |
+ (TypeBindings): |
+ (TypeBindings.create_for_named_type_declaration.ClassBinding.generate_type_builder): |
+ (Generator.process_types): |
+ |
+2011-12-11 Andreas Kling <kling@webkit.org> |
+ |
+ WK2/NetscapePlugin: Incorrect mouse event coordinates when frameScaleFactor != 1. |
+ <http://webkit.org/b/74209> and <rdar://problem/10438197> |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ * WebCore.exp.in: Export AffineTransform::scale(double). |
+ |
+2011-12-10 Andreas Kling <kling@webkit.org> |
+ |
+ Remove OS(SYMBIAN) block from Settings constructor. |
+ <http://webkit.org/b/74248> |
+ |
+ Reviewed by Benjamin Poulain. |
+ |
+ Kill the last OS(SYMBIAN) block in WebKit! |
+ |
+ * page/Settings.cpp: |
+ (WebCore::Settings::Settings): |
+ |
+2011-12-11 Dan Bernstein <mitz@apple.com> |
+ |
+ <rdar://problem/10561285> REGRESSION (r80438): First word on a line or after collapsed space may not be hyphenated even though it should |
+ https://bugs.webkit.org/show_bug.cgi?id=74239 |
+ |
+ Reviewed by Anders Carlsson. |
+ |
+ Tests: fast/text/hyphenate-first-word-after-skipped-space-expected.html |
+ fast/text/hyphenate-first-word-after-skipped-space.html |
+ |
+ * rendering/RenderBlockLineLayout.cpp: |
+ (WebCore::tryHyphenating): Replaced the assumption that the character at lastSpace is a space |
+ iff lastSpace is non-zero with a test of whether it is a space, in the sense that it should |
+ not be counted as part of the prefix when comparing it to the value of hyphenate-limit-before. |
+ |
+2011-12-10 Benjamin Poulain <bpoulain@apple.com> |
+ |
+ #ifdef the parts of the Mac platform which should not be used on iOS |
+ https://bugs.webkit.org/show_bug.cgi?id=74246 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ * Configurations/WebCore.xcconfig: |
+ * platform/FileSystem.cpp: |
+ * platform/mac/FileSystemMac.mm: |
+ * platform/mac/Language.mm: |
+ (+[WebLanguageChangeObserver _webkit_languagePreferencesDidChange]): |
+ (WebCore::createHTTPStyleLanguageCode): |
+ (WebCore::platformDefaultLanguage): |
+ * platform/mac/LocalizedStringsMac.mm: |
+ (WebCore::localizedString): |
+ (+[WebCoreSharedBufferData initialize]): |
+ * platform/mac/WebCoreNSStringExtras.h: |
+ * platform/mac/WebCoreNSStringExtras.mm: |
+ * platform/mac/WebFontCache.mm: |
+ * platform/mac/WebNSAttributedStringExtras.mm: The value NSAttachmentCharacter is |
+ not defined in the iOS SDK so we add it here. |
+ |
+2011-12-10 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ The previous fix broke Lion release build. Fix that. |
+ |
+ * editing/SpellingCorrectionCommand.cpp: |
+ |
+2011-12-10 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Lion build fix attempt after r102527. |
+ |
+ * editing/SpellingCorrectionCommand.cpp: |
+ |
+2011-12-10 Kevin Ollivier <kevino@theolliviers.com> |
+ |
+ [wx] Unreviewed build fixes. Add missing header for CPP |
+ DOM bindings and add stubs for new DPI methods. |
+ |
+ * bindings/scripts/CodeGeneratorCPP.pm: |
+ (AddIncludesForType): |
+ * platform/wx/ScreenWx.cpp: |
+ (WebCore::screenHorizontalDPI): |
+ (WebCore::screenVerticalDPI): |
+ |
+2011-12-10 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ Mac build fix. Remove an erroneous OVERRIDE. |
+ |
+ * editing/CompositeEditCommand.h: |
+ |
+2011-12-09 Robert Hogan <robert@webkit.org> |
+ |
+ CSS 2.1 failure: numerous counter-increment-* tests fail |
+ https://bugs.webkit.org/show_bug.cgi?id=73360 |
+ |
+ Reviewed by Julien Chaffraix. |
+ |
+ Allow counter-increment to handle integer underflow and overflow. |
+ Also allow 'counter' to inherit. |
+ |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyCounter::applyInheritValue): |
+ (WebCore::ApplyPropertyCounter::applyValue): |
+ (WebCore::ApplyPropertyCounter::createHandler): |
+ |
+2011-12-09 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ There should be a way to count the number of nodes held by undo stack |
+ https://bugs.webkit.org/show_bug.cgi?id=74099 |
+ |
+ Reviewed by Enrica Casucci. |
+ |
+ Add getNodesInCommand to all SimpleEditCommands and EditCommandComposition in debug builds. |
+ We can easily aggregate the number of nodes held by the undo stack by calling |
+ this function on each item in the undo stack. |
+ |
+ * editing/AppendNodeCommand.cpp: |
+ (WebCore::AppendNodeCommand::getNodesInCommand): |
+ * editing/AppendNodeCommand.h: |
+ * editing/CompositeEditCommand.cpp: |
+ (WebCore::EditCommandComposition::getNodesInCommand): |
+ * editing/CompositeEditCommand.h: |
+ * editing/DeleteFromTextNodeCommand.cpp: |
+ (WebCore::DeleteFromTextNodeCommand::getNodesInCommand): |
+ * editing/DeleteFromTextNodeCommand.h: |
+ * editing/EditCommand.cpp: |
+ (WebCore::SimpleEditCommand::addNodeAndDescedents): |
+ * editing/EditCommand.h: |
+ * editing/Editor.cpp: |
+ (WebCore::Editor::appliedEditing): |
+ * editing/InsertIntoTextNodeCommand.cpp: |
+ (WebCore::InsertIntoTextNodeCommand::getNodesInCommand): |
+ * editing/InsertIntoTextNodeCommand.h: |
+ * editing/InsertNodeBeforeCommand.cpp: |
+ (WebCore::InsertNodeBeforeCommand::getNodesInCommand): |
+ * editing/InsertNodeBeforeCommand.h: |
+ * editing/MergeIdenticalElementsCommand.cpp: |
+ (WebCore::MergeIdenticalElementsCommand::getNodesInCommand): |
+ * editing/MergeIdenticalElementsCommand.h: |
+ * editing/RemoveCSSPropertyCommand.cpp: |
+ (WebCore::RemoveCSSPropertyCommand::getNodesInCommand): |
+ * editing/RemoveCSSPropertyCommand.h: |
+ * editing/RemoveNodeCommand.cpp: |
+ (WebCore::RemoveNodeCommand::getNodesInCommand): |
+ * editing/RemoveNodeCommand.h: |
+ * editing/ReplaceNodeWithSpanCommand.cpp: |
+ (WebCore::ReplaceNodeWithSpanCommand::getNodesInCommand): |
+ * editing/ReplaceNodeWithSpanCommand.h: |
+ * editing/SetNodeAttributeCommand.cpp: |
+ (WebCore::SetNodeAttributeCommand::getNodesInCommand): |
+ * editing/SetNodeAttributeCommand.h: |
+ * editing/SetSelectionCommand.h: |
+ * editing/SplitElementCommand.cpp: |
+ (WebCore::SplitElementCommand::getNodesInCommand): |
+ * editing/SplitElementCommand.h: |
+ * editing/SplitTextNodeCommand.cpp: |
+ (WebCore::SplitTextNodeCommand::getNodesInCommand): |
+ * editing/SplitTextNodeCommand.h: |
+ * editing/WrapContentsInDummySpanCommand.cpp: |
+ (WebCore::WrapContentsInDummySpanCommand::getNodesInCommand): |
+ * editing/WrapContentsInDummySpanCommand.h: |
+ |
+2011-11-09 Robert Hogan <robert@webkit.org> |
+ |
+ CSS 2.1 failure: outline-color-* tests fail |
+ https://bugs.webkit.org/show_bug.cgi?id=71931 |
+ |
+ Reviewed by Julien Chaffraix. |
+ |
+ Test: css2.1/20110323/outline-color-001.html |
+ |
+ WebKit didn't paint the top block in this series of tests because it ignored the outline |
+ of objects with a zero size. Fix this by taking account of both offset and width of the |
+ outline when deciding whether to paint it. |
+ |
+ * rendering/RenderObject.cpp: |
+ (WebCore::RenderObject::paintOutline): paint the outline even when the block has zero size |
+ |
+2011-12-10 Arko Saha <arko@motorola.com> |
+ |
+ Microdata: Fix compilation error in MICRODATA enabled build. |
+ https://bugs.webkit.org/show_bug.cgi?id=74235 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ * dom/Document.cpp: |
+ (WebCore::Document::getItems): |
+ |
+2011-12-10 Jarred Nicholls <jarred@sencha.com> |
+ |
+ [V8] Remove old ArrayBuffer guards from V8XMLHttpRequestCustom.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=74234 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ No new tests are necessary. |
+ |
+ * bindings/v8/custom/V8XMLHttpRequestCustom.cpp: |
+ (WebCore::V8XMLHttpRequest::responseAccessorGetter): |
+ |
+2011-12-10 Noel Gordon <noel.gordon@gmail.com> |
+ |
+ WebPImageDecoder progressive decodes fail to decode valid images |
+ https://bugs.webkit.org/show_bug.cgi?id=74062 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ The WEBP header is followed by a so-called P0 header, then some data to |
+ decode. If a partial P0 header is received during progressive decodes, |
+ WebPIDecGetRGB() returns false; that makes the decoder enter the failed |
+ state, no image appears on the page. |
+ |
+ James Zern (webp) recommended the following via e-mail: |
+ |
+ WebPIUpdate() validates input data, and will return an error status for |
+ malformed data (bit-stream error, invalid data). Otherwise, it returns |
+ OK or SUSPENDED. OK means that decoding is done/complete/no-error, and |
+ SUSPENDED means more input data is needed to complete decoding. A NULL |
+ return from WebPIDecGetRGB() is valid at this time due to a partial P0, |
+ and should not be interpreted as a decoding failure. |
+ |
+ No new tests. Not something DumpRenderTree can easily test. |
+ |
+ * platform/image-decoders/webp/WEBPImageDecoder.cpp: |
+ (WebCore::WEBPImageDecoder::decode): A NULL WebPIDecGetRGB() return is |
+ acceptable here. Return false instead of failing the decoder. |
+ |
+2011-12-09 Benjamin Poulain <bpoulain@apple.com> |
+ |
+ Add the FileSystem functions of iOS |
+ https://bugs.webkit.org/show_bug.cgi?id=74164 |
+ |
+ Reviewed by David Kilzer. |
+ |
+ Two functions are needed on iOS for temporary files and directories. |
+ |
+ * WebCore.exp.in: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * platform/ios/FileSystemIOS.h: Added. |
+ * platform/ios/FileSystemIOS.mm: Added. |
+ (WebCore::createTemporaryDirectory): |
+ (WebCore::createTemporaryFile): |
+ |
+2011-12-09 Jacky Jiang <zhajiang@rim.com> |
+ |
+ Remove ResourceHandle::bufferedData() from ResourceHandleBlackBerry.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=74197 |
+ |
+ The bufferedData() was removed in r95120. |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Trivial fix, so no new tests. |
+ |
+ * platform/network/blackberry/ResourceHandleBlackBerry.cpp: |
+ |
+2011-12-09 Eric Penner <epenner@google.com> |
+ |
+ [chromium] Prevent ASSERT in legitimate out-of-memory case. |
+ https://bugs.webkit.org/show_bug.cgi?id=74215 |
+ |
+ Reviewed by James Robinson. |
+ |
+ * platform/graphics/chromium/TiledLayerChromium.cpp: |
+ (WebCore::TiledLayerChromium::updateCompositorResources): |
+ |
+2011-12-09 Arko Saha <arko@motorola.com> |
+ |
+ NameNodeListCache should be invalidated when name attribute changes/modified. |
+ https://bugs.webkit.org/show_bug.cgi?id=70810 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Test: fast/dom/getelementsbyname-invalidation-cache.html |
+ |
+ * html/HTMLAnchorElement.cpp: |
+ (WebCore::HTMLAnchorElement::parseMappedAttribute): |
+ * html/HTMLAppletElement.cpp: |
+ (WebCore::HTMLAppletElement::parseMappedAttribute): |
+ * html/HTMLElement.cpp: |
+ (WebCore::HTMLElement::parseMappedAttribute): |
+ * html/HTMLEmbedElement.cpp: |
+ (WebCore::HTMLEmbedElement::parseMappedAttribute): |
+ * html/HTMLFormElement.cpp: |
+ (WebCore::HTMLFormElement::parseMappedAttribute): |
+ * html/HTMLFrameElementBase.cpp: |
+ (WebCore::HTMLFrameElementBase::parseMappedAttribute): |
+ * html/HTMLIFrameElement.cpp: |
+ (WebCore::HTMLIFrameElement::parseMappedAttribute): |
+ * html/HTMLImageElement.cpp: |
+ (WebCore::HTMLImageElement::parseMappedAttribute): |
+ * html/HTMLMapElement.cpp: |
+ (WebCore::HTMLMapElement::parseMappedAttribute): |
+ * html/HTMLMetaElement.cpp: |
+ (WebCore::HTMLMetaElement::parseMappedAttribute): |
+ * html/HTMLObjectElement.cpp: |
+ (WebCore::HTMLObjectElement::parseMappedAttribute): |
+ * html/HTMLParamElement.cpp: |
+ (WebCore::HTMLParamElement::parseMappedAttribute): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix Lion release build. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ |
+2011-12-09 Mark Pilgrim <pilgrim@chromium.org> |
+ |
+ [FileSystem API] Entry.remove successCallback is required |
+ https://bugs.webkit.org/show_bug.cgi?id=69639 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/filesystem/simple-required-arguments-remove.html |
+ |
+ * fileapi/Entry.idl: remove [Optional] flag from Entry.remove.successCallback parameter |
+ |
+2011-12-09 Tim Horton <timothy_horton@apple.com> |
+ |
+ background-image transitions trigger between equivalent images |
+ https://bugs.webkit.org/show_bug.cgi?id=74229 |
+ <rdar://problem/10558627> |
+ |
+ Reviewed by Darin Adler. |
+ Patch by Simon Fraser. |
+ |
+ For animation property wrappers around StyleImage properties, |
+ test the equivalence of the image itself, instead of equality of |
+ the StyleImage pointer. |
+ |
+ Test: transitions/equivalent-background-image-no-transition.html |
+ |
+ * page/animation/AnimationBase.cpp: |
+ (WebCore::StyleImagePropertyWrapper::StyleImagePropertyWrapper): |
+ (WebCore::StyleImagePropertyWrapper::equals): |
+ (WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper): |
+ (WebCore::FillLayerStyleImagePropertyWrapper::equals): |
+ (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): |
+ (WebCore::AnimationBase::ensurePropertyMap): |
+ |
+2011-12-09 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Small style fix on DragDataBlackBerry.cpp |
+ https://bugs.webkit.org/show_bug.cgi?id=74171 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Style fix, no function impact, no new tests. |
+ |
+ * platform/blackberry/DragDataBlackBerry.cpp: |
+ (WebCore::DragData::containsURL): |
+ (WebCore::DragData::asFilenames): |
+ (WebCore::DragData::asURL): |
+ (WebCore::DragData::asFragment): |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ add css parsing for flex-flow: wrap and wrap-reverse |
+ https://bugs.webkit.org/show_bug.cgi?id=74008 |
+ |
+ Reviewed by Ojan Vafai. |
+ |
+ Also save 2 bits in StyleFlexibleBoxData by changing the size of m_flexFlow (there are only 4 enum values). |
+ |
+ * css/CSSComputedStyleDeclaration.cpp: |
+ (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Print the wrap value if it exists. |
+ * css/CSSParser.cpp: |
+ (WebCore::CSSParser::parseValue): Parse a second token and put the values into a CSSValueList. |
+ * css/CSSPrimitiveValueMappings.h: |
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): |
+ (WebCore::CSSPrimitiveValue::operator EFlexWrap): |
+ * css/CSSStyleApplyProperty.cpp: |
+ (WebCore::ApplyPropertyFlexFlow::applyInheritValue): Does not inherit. |
+ (WebCore::ApplyPropertyFlexFlow::applyInitialValue): |
+ (WebCore::ApplyPropertyFlexFlow::applyValue): Special handler for setting two render style values from one |
+ CSS property. |
+ (WebCore::ApplyPropertyFlexFlow::createHandler): |
+ (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): |
+ * css/CSSValueKeywords.in: |
+ * rendering/style/RenderStyle.h: |
+ (WebCore::InheritedFlags::flexWrap): |
+ (WebCore::InheritedFlags::setFlexWrap): |
+ (WebCore::InheritedFlags::initialFlexWrap): |
+ * rendering/style/RenderStyleConstants.h: EFlexWrap to hold flex wrap values. |
+ * rendering/style/StyleFlexibleBoxData.cpp: |
+ (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): |
+ (WebCore::StyleFlexibleBoxData::operator==): |
+ * rendering/style/StyleFlexibleBoxData.h: 2 bits is enough to hold the 4 flexFlow values. |
+ |
+2011-12-09 KwangHyuk Kim <hyuki.kim@samsung.com> |
+ |
+ [EFL] Add RefPtrEfl specialization for evas_object. |
+ https://bugs.webkit.org/show_bug.cgi?id=73790 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ As evas_object is also based on reference count, RefPtr is applied for evas_object. |
+ |
+ * PlatformEfl.cmake: |
+ * platform/efl/RefPtrEfl.cpp: Added. |
+ (WTF::refIfNotNull): |
+ (WTF::derefIfNotNull): |
+ * platform/efl/RefPtrEfl.h: Added. |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ REGRESSION(102234): 2-3% layout regression |
+ https://bugs.webkit.org/show_bug.cgi?id=74141 |
+ |
+ Reviewed by David Hyatt. |
+ |
+ Don't allocate a RuleSet when there are no regions. |
+ |
+ * css/CSSStyleSelector.cpp: |
+ (WebCore::CSSStyleSelector::initForRegionStyling): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Fix assertion failure in ScrollAnimatorMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74222 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): |
+ This can be called with a nil scrollerImp, just return NSZeroPoint when that happens. |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Move the "is currently drawing into layer" flag out into ScrollbarThemeMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74217 |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ There's no need to store this flag inside ScrollAnimatorMac, just make it a global and put it in ScrollbarThemeMac instead. |
+ |
+ * platform/mac/ScrollAnimatorMac.h: |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ * platform/mac/ScrollbarThemeMac.h: |
+ * platform/mac/ScrollbarThemeMac.mm: |
+ (WebCore::ScrollbarThemeMac::isCurrentlyDrawingIntoLayer): |
+ (WebCore::ScrollbarThemeMac::paint): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Minor cleanup in ScrollAnimatorMac.mm |
+ https://bugs.webkit.org/show_bug.cgi?id=74211 |
+ |
+ Reviewed by Andreas Kling. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ No need to get the scrollbar from the scroll animator anymore. |
+ |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ Try to get data from the scrollbar and/or the scrollable area instead of the scrollbar painter. |
+ |
+2011-12-09 David Levin <levin@chromium.org> |
+ |
+ Regression(r53595): Sync xhr requests in workers aren't terminated on worker close. |
+ https://bugs.webkit.org/show_bug.cgi?id=71695 |
+ |
+ Reviewed by Zoltan Herczeg. |
+ |
+ Overview: Message loops rely on the message queue being killed in order |
+ to exit. r53595 stopped this from happening because killing a message loop |
+ would also stop it from doing database clean up tasks. The database clean up |
+ tasks needed to be tasks due to ordering issues. (They wanted to run after |
+ certain order tasks were run.) This was solved by once again terminating |
+ the message queue but then still runnning clean-up tasks from the killed |
+ message queue. |
+ |
+ * workers/WorkerRunLoop.cpp: |
+ (WebCore::WorkerRunLoop::run): Added the call to run clean-up tasks. |
+ (WebCore::WorkerRunLoop::runInMode): |
+ (WebCore::WorkerRunLoop::runCleanupTasks): Loop to simply clear out all clean up tasks. |
+ (WebCore::WorkerRunLoop::Task::performTask): Stop non-clean up tasks |
+ from running after the loop has been terminated. |
+ * workers/WorkerRunLoop.h: |
+ (WebCore::WorkerRunLoop::terminated): Just made it const. |
+ * workers/WorkerThread.cpp: |
+ (WebCore::WorkerThreadShutdownFinishTask::performTask): Removed |
+ the terminate clause since it was put back in stop. |
+ (WebCore::WorkerThread::stop): Terminate the run loop so |
+ that all loops will exit and clean up tasks will run. Also removed a comment |
+ about nested workers because nested workers are no longer imminent and the |
+ issue mentioned is one of many that should logically be investigated -- behavior correctness |
+ in the face of different orderings of shutdown between the document and each worker -- |
+ when implementing them. |
+ |
+2011-12-09 Tony Chang <tony@chromium.org> |
+ |
+ Unreviewed, rolling out r102416. |
+ http://trac.webkit.org/changeset/102416 |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Chromium Win clobber builds are failing. |
+ |
+ * WebCore.gyp/WebCore.gyp: |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): |
+ * WebCore.gypi: |
+ * bindings/scripts/generate-bindings.pl: |
+ * page/DOMWindow.idl: |
+ * webaudio/DOMWindowWebAudio.idl: Removed. |
+ |
+2011-12-09 Eric Carlson <eric.carlson@apple.com> |
+ |
+ JSC wrappers for TextTrack and TextTrackCue should not be collected during event dispatch or when owner is reachable |
+ https://bugs.webkit.org/show_bug.cgi?id=72179 |
+ |
+ Reviewed by Geoff Garen. |
+ |
+ Tests: media/track/text-track-cue-is-reachable.html |
+ media/track/text-track-is-reachable.html |
+ |
+ * GNUmakefile.list.am: Add JSTextTrackCueCustom.cpp and JSTextTrackCustom.cpp. |
+ * Target.pri: Ditto. |
+ * WebCore.gypi: Ditto. |
+ * WebCore.xcodeproj/project.pbxproj: Ditto |
+ * bindings/js/JSBindingsAllInOne.cpp: Ditto. |
+ |
+ * bindings/js/JSTextTrackCueCustom.cpp: Added. |
+ (WebCore::JSTextTrackCueOwner::isReachableFromOpaqueRoots): New. |
+ (WebCore::JSTextTrackCueOwner::visitChildren): New. |
+ |
+ * bindings/js/JSTextTrackCustom.cpp: Added. |
+ (WebCore::JSTextTrackOwner::isReachableFromOpaqueRoots): New. |
+ (WebCore::JSTextTrack::visitChildren): New, mark all cues. |
+ * bindings/js/JSTextTrackCustom.h: Added. |
+ (WebCore::root): New. |
+ |
+ * bindings/js/JSTextTrackListCustom.cpp: |
+ (WebCore::JSTextTrackList::visitChildren): New, mark all tracks. |
+ |
+ * html/HTMLMediaElement.cpp: |
+ (WebCore::HTMLMediaElement::trackWillBeRemoved): TextTracks::remove now takes a TextTrack*. |
+ |
+ * html/LoadableTextTrack.h: |
+ (WebCore::LoadableTextTrack::trackElement): New, return the <track>. |
+ |
+ * html/TextTrack.cpp: |
+ (WebCore::TextTrack::TextTrack): Initialize m_mediaElement. |
+ * html/TextTrack.h: |
+ (WebCore::TextTrack::setMediaElement): New. |
+ (WebCore::TextTrack::mediaElement): Ditto. |
+ |
+ * html/TextTrack.idl: Add CustomIsReachable and CustomMarkFunction. |
+ |
+ * html/TextTrackCue.idl: Add CustomIsReachable. |
+ |
+ * html/track/TextTrackList.cpp: |
+ (TextTrackList::append): Set track's media element. |
+ (TextTrackList::remove): Clear track's media element. Take a raw ptr, not a PassRefPtr. |
+ * html/track/TextTrackList.h: |
+ * html/track/TextTrackList.idl: Add CustomMarkFunction |
+ |
+2011-12-09 Chris Fleizach <cfleizach@apple.com> |
+ |
+ WebKit should ignore images with @alt matching only whitespace |
+ https://bugs.webkit.org/show_bug.cgi?id=74189 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Test: accessibility/img-alt-tag-only-whitespace.html |
+ |
+ * accessibility/AccessibilityRenderObject.cpp: |
+ (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove NSAnimationContext calls |
+ https://bugs.webkit.org/show_bug.cgi?id=74207 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ NSAnimationContext is not used for NSAnimation subclasses, so the calls to beginGrouping/endGrouping and setDuration: |
+ are essentially no-ops. Remove them. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Rename scrollAnimatorDestroyed to invalidate |
+ https://bugs.webkit.org/show_bug.cgi?id=74206 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Since these methods can be called when both scrollbars are destroyed and the scroll animator itself is |
+ destroyed, rename it to something more neutral. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollAnimationHelperDelegate invalidate]): |
+ (-[WebScrollbarPartAnimation invalidate]): |
+ (-[WebScrollbarPainterDelegate invalidate]): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPainterControllerDelegate should know about the ScrollableArea, not the ScrollAnimatorMac |
+ https://bugs.webkit.org/show_bug.cgi?id=74204 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ It makes more logical sense to associate the WebScrollbarPainterControllerDelegate object with its ScrollableArea, since |
+ painting has nothing to do with animation. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterControllerDelegate initWithScrollableArea:]): |
+ (-[WebScrollbarPainterControllerDelegate invalidate]): |
+ (-[WebScrollbarPainterControllerDelegate contentAreaRectForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate inLiveResizeForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate mouseLocationInContentAreaForScrollerImpPair:]): |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]): |
+ (-[WebScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]): |
+ (WebCore::ScrollAnimatorMac::ScrollAnimatorMac): |
+ (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac): |
+ |
+2011-12-09 Jarred Nicholls <jarred@sencha.com> |
+ |
+ [JSC] Allow cached attributes in bindings that declare a custom mark function |
+ https://bugs.webkit.org/show_bug.cgi?id=74187 |
+ |
+ Reviewed by Oliver Hunt. |
+ |
+ No new tests, current binding tests are sufficient. |
+ |
+ * bindings/scripts/CodeGeneratorJS.pm: |
+ (GenerateImplementation): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ Remove duplicate animation ivars |
+ https://bugs.webkit.org/show_bug.cgi?id=74194 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ Since we now have one WebScrollbarPainterDelegate for each scrollbar, we no longer need separate |
+ vertical/horizontal animation objects, so get rid of them. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate cancelAnimations]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): |
+ |
+2011-12-09 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPartAnimation should only know about the scrollbar it's animating |
+ https://bugs.webkit.org/show_bug.cgi?id=74192 |
+ |
+ Reviewed by Sam Weinig. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPartAnimation initWithScrollbar:featureToAnimate:animateFrom:animateTo:duration:]): |
+ Change the designated initializer to just take the scrollbar. Also, make the animation non-blocking here |
+ so we don't have to do it in all the call sites. |
+ |
+ (-[WebScrollbarPartAnimation startAnimation]): |
+ Update the scrollbar painter. |
+ |
+ (-[WebScrollbarPartAnimation setCurrentProgress:]): |
+ Just invalidate the scrollbar we're animating. |
+ |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ Update call sites to use the new designated initializer. |
+ |
+2011-12-08 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> |
+ |
+ Inspector: Don't translate the context when rendering the highlights on a tiled layer. |
+ https://bugs.webkit.org/show_bug.cgi?id=74085 |
+ |
+ Reviewed by Kenneth Rohde Christiansen. |
+ |
+ When the frame view is using fixed layouting, the page overlay is the size of the whole |
+ page and the context shouldn't be translated. The visible rect is still used in that |
+ case to display element titles within the visible rect. |
+ |
+ Also: |
+ - Rename overlayRect to visibleRect to reduce confusion in this case. |
+ - Remove the superfluous boundingBox check. |
+ |
+ * inspector/DOMNodeHighlighter.cpp: |
+ |
+2011-12-09 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Unreviewed inspector utilities syntax fix. |
+ |
+ * inspector/front-end/utilities.js: |
+ (): |
+ |
+2011-12-09 Joone Hur <joone.hur@collabora.co.uk>, Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> |
+ |
+ [GTK] Initial implementation of Accelerated Compositing using Clutter |
+ https://bugs.webkit.org/show_bug.cgi?id=73319 |
+ |
+ Reviewed by Gustavo Noronha Silva. |
+ |
+ No new tests added as this feature will be able to reuse the existing |
+ CSS3 transforms layout tests. |
+ |
+ * GNUmakefile.am: Include WebCore/platform/graphics/clutter path. |
+ * GNUmakefile.list.am: Add GraphicsLayerClutter. |
+ * platform/clutter/GRefPtrClutter.cpp: Added. |
+ (WTF::adoptGRef): |
+ (WTF::ClutterActor): |
+ * platform/clutter/GRefPtrClutter.h: Added. |
+ * platform/graphics/GraphicsLayer.h: Define PlatformLayer type, which represents ClutterActor. |
+ * platform/graphics/clutter/GraphicsLayerClutter.cpp: Boilerplate implementation. |
+ (WebCore::GraphicsLayerClutter::GraphicsLayerClutter): |
+ (WebCore::GraphicsLayerClutter::platformLayer): |
+ * platform/graphics/clutter/GraphicsLayerClutter.h: Boilerplate implementation. |
+ |
+2011-12-08 Vsevolod Vlasov <vsevik@chromium.org> |
+ |
+ Web Inspector: Introduce a Map class allowing to store values indexed by arbitrary objects. |
+ https://bugs.webkit.org/show_bug.cgi?id=74084 |
+ |
+ Reviewed by Pavel Feldman. |
+ |
+ Test: inspector/map.html |
+ |
+ * inspector/front-end/treeoutline.js: |
+ (TreeOutline): |
+ (): |
+ (TreeElement.prototype.collapse): |
+ (TreeElement.prototype.expand): |
+ * inspector/front-end/utilities.js: |
+ (): |
+ |
+2011-12-09 Peter Rybin <peter.rybin@gmail.com> |
+ |
+ Web Inspector: [protocol] generate C++ classes for protocol JSON named types |
+ https://bugs.webkit.org/show_bug.cgi?id=72835 |
+ |
+ Reviewed by Yury Semikhatsky. |
+ |
+ Extends python generator functionality. |
+ Makes constructor in InspectorObject public. |
+ |
+ * inspector/CodeGeneratorInspector.py: |
+ * inspector/InspectorValues.h: |
+ |
+2011-12-08 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> |
+ |
+ [Qt] [WK2] Webkit should release TextureMapper GL objects if page paint node is deallocated. |
+ https://bugs.webkit.org/show_bug.cgi?id=73591 |
+ |
+ Reviewed by Noam Rosenthal. |
+ |
+ Implementation of helper function to remove all GL allocated tiles |
+ when QQuickWebView gets removed from canvas. |
+ |
+ Tested by new API test in WK2 (tst_QQuickWebView::removeFromCanvas). |
+ |
+ * platform/graphics/texmap/TextureMapperNode.cpp: |
+ (WebCore::TextureMapperNode::purgeNodeTexturesRecursive): |
+ * platform/graphics/texmap/TextureMapperNode.h: |
+ |
+2011-12-08 Leo Yang <leo.yang@torchmobile.com.cn> |
+ |
+ Upstream platform/network/blackberry/DeferredData.{h, cpp}, NetworkJob.{h, cpp} and NetworkManager.{h, cpp} |
+ https://bugs.webkit.org/show_bug.cgi?id=73791 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Other main contributors: |
+ Joe Mason <jmason@rim.com> |
+ Lianghui Chen <liachen@rim.com> |
+ Charles Wei <charles.wei@torchmobile.com.cn> |
+ |
+ Initial upstream, can't be built yet, no new tests. |
+ |
+ * platform/network/blackberry/DeferredData.cpp: Added. |
+ * platform/network/blackberry/DeferredData.h: Added. |
+ * platform/network/blackberry/NetworkJob.cpp: Added. |
+ * platform/network/blackberry/NetworkJob.h: Added. |
+ * platform/network/blackberry/NetworkManager.cpp: Added. |
+ * platform/network/blackberry/NetworkManager.h: Added. |
+ |
+2011-12-08 Ryosuke Niwa <rniwa@webkit.org> |
+ |
+ It's semantically incorrect to call notifyNodeListsAttributeChanged in dispatchSubtreeModifiedEvent |
+ https://bugs.webkit.org/show_bug.cgi?id=74028 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Remove a call to notifyNodeListsAttributeChanged in dispatchSubtreeModified and add explicit calls |
+ to notifyNodeListsAttributeChanged at appropriate places. |
+ |
+ Also merge notifyNodeListsChildrenChanged with notifyLocalNodeListsChildrenChanged, and |
+ notifyNodeListsAttributeChanged with notifyLocalNodeListsAttributeChanged, and rename them to |
+ invalidateNodeListsCacheAfterAttributeChanges and invalidateNodeListsCacheAfterNodeChanges respectively. |
+ |
+ * dom/Attr.cpp: |
+ (WebCore::Attr::childrenChanged): |
+ * dom/ContainerNode.cpp: |
+ (WebCore::ContainerNode::childrenChanged): |
+ * dom/Document.cpp: |
+ (WebCore::Document::updateRangesAfterNodeChanges): |
+ * dom/Document.h: |
+ * dom/NamedNodeMap.cpp: |
+ (WebCore::NamedNodeMap::addAttribute): |
+ (WebCore::NamedNodeMap::removeAttribute): |
+ * dom/Node.cpp: |
+ (WebCore::removeNodeListCacheIfPossible): |
+ (WebCore::Node::unregisterDynamicNodeList): |
+ (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanges): |
+ (WebCore::Node::invalidateNodeListsCacheAfterNodeChanges): |
+ (WebCore::Node::dispatchSubtreeModifiedEvent): |
+ * dom/Node.h: |
+ * dom/NodeRareData.h: |
+ * dom/StyledElement.cpp: |
+ (WebCore::StyledElement::classAttributeChanged): |
+ |
+2011-12-08 Kenichi Ishibashi <bashi@chromium.org> |
+ |
+ Unreviewed, rolling out r102418. |
+ http://trac.webkit.org/changeset/102418 |
+ https://bugs.webkit.org/show_bug.cgi?id=71870 |
+ |
+ Caused Chromium build failure. |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.make: |
+ * DerivedSources.pri: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: |
+ (WebCore::toV8Object): |
+ * html/canvas/WebGLExtension.h: |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::getExtension): |
+ (WebCore::WebGLRenderingContext::getSupportedExtensions): |
+ (WebCore::WebGLRenderingContext::maybeRestoreContext): |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebKitLoseContext.cpp: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.cpp. |
+ (WebCore::WebKitLoseContext::WebKitLoseContext): |
+ (WebCore::WebKitLoseContext::~WebKitLoseContext): |
+ (WebCore::WebKitLoseContext::getName): |
+ (WebCore::WebKitLoseContext::create): |
+ (WebCore::WebKitLoseContext::loseContext): |
+ (WebCore::WebKitLoseContext::restoreContext): |
+ * html/canvas/WebKitLoseContext.h: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.h. |
+ * html/canvas/WebKitLoseContext.idl: Renamed from Source/WebCore/html/canvas/WebGLLoseContext.idl. |
+ |
+2011-12-08 Fady Samuel <fsamuel@chromium.org> |
+ |
+ [Chromium] Enable viewport metatag |
+ https://bugs.webkit.org/show_bug.cgi?id=73495 |
+ |
+ Reviewed by Darin Fisher. |
+ |
+ Recompute viewpot parameters on frame rect resize. |
+ |
+ * page/FrameView.cpp: |
+ (WebCore::FrameView::setFrameRect): |
+ |
+2011-12-08 Kent Tamura <tkent@chromium.org> |
+ |
+ Build fix for r102419. |
+ https://bugs.webkit.org/show_bug.cgi?id=73916 |
+ |
+ * platform/PopupMenuClient.h: |
+ (WebCore::PopupMenuClient::listBoxSelectItem): |
+ Remove unused argument names. |
+ |
+2011-12-08 Kentaro Hara <haraken@chromium.org> |
+ |
+ Unreviewed. Rebaselined run-bindings-tests results. |
+ |
+ * bindings/scripts/test/JS/JSFloat64Array.cpp: |
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp: |
+ * bindings/scripts/test/JS/JSTestInterface.cpp: |
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: |
+ * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: |
+ * bindings/scripts/test/JS/JSTestObj.cpp: |
+ * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: |
+ |
+2011-12-08 Mary Wu <mary.wu@torchmobile.com.cn> |
+ |
+ Upstream BlackBerry porting of MIMETypeRegistry/KeyboardEvent |
+ https://bugs.webkit.org/show_bug.cgi?id=73534 |
+ |
+ Reviewed by Rob Buis. |
+ |
+ Other main contributors: |
+ Mike Fenton <mifenton@rim.com> |
+ Joe Mason <jmason@rim.com> |
+ Max Feil <mfeil@qnx.com> |
+ Lukas Sydorowski <lsydorowski@rim.com> |
+ Crystal Zhang <haizhang@rim.com> |
+ |
+ Initial upstream, no new tests. |
+ |
+ * platform/blackberry/MIMETypeRegistryBlackBerry.cpp: Added. |
+ (WebCore::MIMETypeRegistry::getMIMETypeForExtension): |
+ (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType): |
+ (WebCore::MIMETypeRegistry::isApplicationPluginMIMEType): |
+ * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp: Added. |
+ (WebCore::keyIdentifierForBlackBerryCharacter): |
+ (WebCore::windowsKeyCodeForBlackBerryCharacter): |
+ (WebCore::adjustCharacterFromOS): |
+ (WebCore::toWebCorePlatformKeyboardEventType): |
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): |
+ (WebCore::PlatformKeyboardEvent::currentCapsLockState): |
+ (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): |
+ (WebCore::PlatformKeyboardEvent::getCurrentModifierState): |
+ |
+2011-12-08 Sheriff Bot <webkit.review.bot@gmail.com> |
+ |
+ Unreviewed, rolling out r101619. |
+ http://trac.webkit.org/changeset/101619 |
+ https://bugs.webkit.org/show_bug.cgi?id=74158 |
+ |
+ this patch produces bad behaviour on mac (Requested by |
+ jeremya_ on #webkit). |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::handleMouseMoveEvent): |
+ (WebCore::EventHandler::dragSourceEndedAt): |
+ * rendering/RenderLayer.cpp: |
+ (WebCore::RenderLayer::updateHoverActiveState): |
+ |
+2011-12-08 Adam Klein <adamk@chromium.org> |
+ |
+ [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics |
+ https://bugs.webkit.org/show_bug.cgi?id=73492 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ Test: fast/mutation/inline-event-listener.html |
+ |
+ * bindings/v8/V8LazyEventListener.cpp: |
+ (WebCore::V8LazyEventListener::prepareListenerObject): Call v8::Script::Run directly instead of going through V8Proxy. |
+ |
+2011-12-08 Hayato Ito <hayato@chromium.org> |
+ |
+ Suppress rendering of light children when ShadowRoot is dynamically created. |
+ https://bugs.webkit.org/show_bug.cgi?id=72441 |
+ |
+ Reviewed by Ryosuke Niwa. |
+ |
+ Tests: fast/dom/shadow/dynamically-created-shadow-root-expected.html |
+ fast/dom/shadow/dynamically-created-shadow-root.html |
+ |
+ * dom/Element.cpp: |
+ (WebCore::Element::setShadowRoot): |
+ |
+2011-12-08 Pierre Rossi <pierre.rossi@gmail.com> |
+ |
+ Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision. |
+ https://bugs.webkit.org/show_bug.cgi?id=73916 |
+ |
+ This was needed for Qt since the mobile theme, which can be picked |
+ up at runtime, delegates the rendering of list boxes. |
+ |
+ Reviewed by Kent Tamura. |
+ |
+ No new tests, there's no functional change. |
+ |
+ * html/HTMLSelectElement.cpp: |
+ (WebCore::HTMLSelectElement::usesMenuList): |
+ * html/HTMLSelectElement.h: |
+ * platform/PopupMenuClient.h: |
+ (WebCore::PopupMenuClient::listBoxSelectItem): |
+ (WebCore::PopupMenuClient::multiple): |
+ * platform/qt/RenderThemeQtMobile.h: |
+ (WebCore::RenderThemeQtMobile::delegatesMenuListRendering): |
+ * rendering/RenderMenuList.cpp: |
+ (WebCore::RenderMenuList::multiple): |
+ * rendering/RenderMenuList.h: |
+ * rendering/RenderTheme.h: |
+ (WebCore::RenderTheme::delegatesMenuListRendering): |
+ |
+2011-12-08 Kenneth Russell <kbr@google.com> |
+ |
+ Rename WEBKIT_lose_context to WEBKIT_WEBGL_lose_context |
+ https://bugs.webkit.org/show_bug.cgi?id=71870 |
+ |
+ Reviewed by James Robinson. |
+ |
+ Rename largely done with do-webcore-rename with a couple of |
+ necessary manual fixups. Ran WebGL layout tests. |
+ |
+ * CMakeLists.txt: |
+ * DerivedSources.make: |
+ * DerivedSources.pri: |
+ * GNUmakefile.list.am: |
+ * Target.pri: |
+ * WebCore.gypi: |
+ * WebCore.xcodeproj/project.pbxproj: |
+ * bindings/js/JSWebGLRenderingContextCustom.cpp: |
+ (WebCore::toJS): |
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: |
+ (WebCore::toV8Object): |
+ * html/canvas/WebGLExtension.h: |
+ * html/canvas/WebGLLoseContext.cpp: Copied from Source/WebCore/html/canvas/WebKitLoseContext.cpp. |
+ (WebCore::WebGLLoseContext::WebGLLoseContext): |
+ (WebCore::WebGLLoseContext::~WebGLLoseContext): |
+ (WebCore::WebGLLoseContext::getName): |
+ (WebCore::WebGLLoseContext::create): |
+ (WebCore::WebGLLoseContext::loseContext): |
+ (WebCore::WebGLLoseContext::restoreContext): |
+ * html/canvas/WebGLLoseContext.h: Copied from Source/WebCore/html/canvas/WebKitLoseContext.h. |
+ * html/canvas/WebGLLoseContext.idl: Copied from Source/WebCore/html/canvas/WebKitLoseContext.idl. |
+ * html/canvas/WebGLRenderingContext.cpp: |
+ (WebCore::WebGLRenderingContext::getExtension): |
+ (WebCore::WebGLRenderingContext::getSupportedExtensions): |
+ (WebCore::WebGLRenderingContext::maybeRestoreContext): |
+ * html/canvas/WebGLRenderingContext.h: |
+ * html/canvas/WebKitLoseContext.cpp: Removed. |
+ * html/canvas/WebKitLoseContext.h: Removed. |
+ * html/canvas/WebKitLoseContext.idl: Removed. |
+ |
+2011-12-08 Kentaro Hara <haraken@chromium.org> |
+ |
+ Use the [Supplemental] IDL for webaudio attributes in Chromium |
+ https://bugs.webkit.org/show_bug.cgi?id=73394 |
+ |
+ Reviewed by Adam Barth. |
+ |
+ - Overview: Using the [Supplemental] IDL, this patch moves the attribute |
+ declarations of webaudio from DOMWindow.idl into a new IDL file |
+ webaudio/DOMWindowWebAudio.idl, which helps make webaudio a self-contained |
+ feature (aka a module). |
+ |
+ - This patch changes the build flow of WebCore.gyp as follows: |
+ |
+ Previous build flow: |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl generates .h and .cpp files for $idl; |
+ } |
+ |
+ New build flow (See the discussions in bug 72138 for more details): |
+ resolve-supplemental.pl depends on all IDL files; |
+ resolve-supplemental.pl reads all IDL files; |
+ resolve-supplemental.pl resolves the dependency of [Supplemental=XXXX]; |
+ resolve-supplemental.pl outputs supplemental_dependency.tmp; |
+ foreach $idl (all IDL files) { |
+ generate-bindings.pl depends on $idl and supplemental_dependency.tmp; |
+ generate-bindings.pl reads $idl; |
+ generate-bindings.pl reads supplemental_dependency.tmp; |
+ generate-bindings.pl generates .h and .cpp files for $idl, including all attributes in IDL files whilementing $idl; |
+ } |
+ |
+ - This patch introduces a temporary IDL, [Supplemented]. The [Supplemented] IDL |
+ will be removed after build scripts for all platforms support the [Supplemental] IDL. |
+ The motivation for the [Supplemented] IDL is as follows: |
+ |
+ In order to support the [Supplemental] IDL, we need to |
+ (1) run resolve-supplemental.pl and generate supplemental_dependency.tmp |
+ (2) and run generate-bindings.pl with the supplemental_dependency.tmp. |
+ |
+ This build flow requires a change on the following build scripts, |
+ but changing all the build scripts all at once without any regression is too difficult: |
+ |
+ - DerivedSources.make |
+ - DerivedSources.pri |
+ - GNUmakefile.am |
+ - PlatformBlackBerry.cmake |
+ - UseJSC.cmake |
+ - UseV8.cmake |
+ - WebCore.vcproj/MigrateScripts |
+ - WebCore.vcproj/WebCore.vcproj |
+ - bindings/gobject/GNUmakefile.am |
+ - WebCore.gyp/WebCore.gyp |
+ |
+ Thus, we are planning to change the build scripts one by one, which implies that |
+ we need to allow the temporary state in which some build scripts support [Supplemental] IDL |
+ but others do not. To accomplish this, we introduce a temporary IDL, [Supplemented]. |
+ The [Supplemented] IDL on an attribute means that the attribute is marked with [Supplemental] |
+ in another IDL file somewhere, like this: |
+ |
+ DOMWindowWebAudio.idl: |
+ interface [ |
+ Supplemental=DOMWindow |
+ ] DOMWindowWebAudio { |
+ attribute attr1; |
+ attribute attr2; |
+ }; |
+ |
+ DOMWindow.idl: |
+ interface [ |
+ ] DOMWindow { |
+ attribute [Supplemented] attr1; // This line will be removed after all build scripts support the [Su IDL |
+ attribute [Supplemented] attr2; // This line will be removed after all build scripts support the [Su IDL. |
+ attribute attr3; |
+ attribute attr4; |
+ }; |
+ |
+ Assuming these IDL files, this patch implements the following logic in generate-bindings.pl: |
+ |
+ - If a given build script supports the [Supplemental] IDL, |
+ generate-bindings.pl ignores all attributes with the [Supplemented] IDL. |
+ - Otherwise, generate-bindings.pl treats all attributes with the [Supplemented] IDL |
+ as normal attributes and instead ignores all attributes with the [Supplemental] IDL |
+ (i.e. generate-bindings.pl generates nothing from the IDL file with the [Supplemental] IDL). |
+ |
+ Tests: webaudio/* |
+ |
+ * WebCore.gyp/WebCore.gyp: Describes the build flow that I described above. |
+ * WebCore.gyp/scripts/action_derivedsourcesallinone.py: |
+ (main): Reads the IDL file names from the input file (i.e. supplemental_dependency.tmp), which are described at the first column of each line in the input file. If the file name is a "/cygdrive/c/..."-style path, it is converted to a "C:\cygwin\..."-style path by the cygpath command. |
+ * WebCore.gypi: Added DOMWindowWebAudio.idl. |
+ * bindings/scripts/generate-bindings.pl: As a temporary solution, if the platform does not support the [Supplemental] IDL, the perl script ignores the [Supplemental] IDL and instead uses the [Supplemented] IDL. Otherwise, the perl script ignores the [Supplemented] IDL and instead uses the [Supplemental] IDL. |
+ * page/DOMWindow.idl: Added the [Supplemented] IDL to webaudio-related attributes. As I described above, the [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL. |
+ * webaudio/DOMWindowWebAudio.idl: Added. Describes the [Supplemental=DOMWindow] IDL. The attributes in this IDL file should be treated as if they are written in DOMWindow.idl. |
+ |
+2011-12-08 Van Lam <vanlam@google.com> |
+ |
+ Caret keeps blinking during forward-delete |
+ https://bugs.webkit.org/show_bug.cgi?id=38564 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Currently updateAppearance determines if the caret should stop blinking |
+ based on whether or not the editing operation changed the position of |
+ the caret; so the caret stops blinking in case of typing text and |
+ backwards delete (which always displace the caret) but does not stop |
+ blinking in the case of forward delete (which does not displace the |
+ caret). |
+ |
+ Added a boolean member function shouldStopCaretBlinking in EditCommand |
+ which will return true if the object is a TypingCommand (my |
+ understanding here is that all TypingCommands should stop the caret |
+ from blinking for a cycle, currently 0.5 seconds). Then used this |
+ function to stop the caret from blinking if the last editing command |
+ is a TypingCommand. |
+ |
+ * editing/EditCommand.h: |
+ (WebCore::EditCommand::shouldStopCaretBlinking): |
+ * editing/FrameSelection.cpp: |
+ (WebCore::FrameSelection::updateAppearance): |
+ * editing/TypingCommand.h: |
+ (WebCore::TypingCommand::shouldStopCaretBlinking): |
+ |
+2011-12-08 Adam Klein <adamk@chromium.org> |
+ |
+ Use HashMap<Node*, OwnPtr<...>> in ChildListMutationScope |
+ https://bugs.webkit.org/show_bug.cgi?id=73964 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ Re-landing r102267 with a fix for the clang build. |
+ |
+ No new tests, refactoring only. |
+ |
+ * dom/ChildListMutationScope.cpp: |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::childAdded): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::willRemoveChild): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel): |
+ (WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::decrementScopingLevel): |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ WebScrollbarPainterDelegate should have a pointer to its Scrollbar |
+ https://bugs.webkit.org/show_bug.cgi?id=74149 |
+ |
+ Reviewed by Darin Adler. |
+ |
+ This is another step towards making the scroll animation code more robust. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate initWithScrollbar:WebCore::]): |
+ (-[WebScrollbarPainterDelegate scrollAnimator]): |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ (-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]): |
+ (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): |
+ (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): |
+ |
+2011-12-08 Rakesh KN <rakesh.kn@motorola.com> |
+ |
+ keyboard event doesn't fire while moving mouse with button pressed |
+ https://bugs.webkit.org/show_bug.cgi?id=73821 |
+ |
+ Reviewed by Alexey Proskuryakov. |
+ |
+ Autoscroll should not stop on key press. |
+ |
+ Test: fast/events/autoscroll-should-not-stop-on-keypress.html |
+ |
+ * page/EventHandler.cpp: |
+ (WebCore::EventHandler::keyEvent): |
+ Removed the check for autoscroll so that autoscroll is not stopped on |
+ key press and key event is processed. |
+ |
+2011-12-08 Anders Carlsson <andersca@apple.com> |
+ |
+ Add scrollAnimator getter method to WebScrollbarPainterDelegate |
+ https://bugs.webkit.org/show_bug.cgi?id=74146 |
+ |
+ Reviewed by Beth Dakin. |
+ |
+ * platform/mac/ScrollAnimatorMac.mm: |
+ (-[WebScrollbarPainterDelegate scrollAnimator]): |
+ (-[WebScrollbarPainterDelegate layer]): |
+ (-[WebScrollbarPainterDelegate mouseLocationInScrollerForScrollerImp:]): |
+ (-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]): |
+ (-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]): |
+ |
2011-12-08 James Robinson <jamesr@chromium.org> |
Improve handling of frame removal during requestAnimationFrame callback invocation |