Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 8890075: Add DEPS file disallowing content/public to depend back to content/. (Closed)

Created:
9 years ago by Jói
Modified:
9 years ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jabdelmalek
Visibility:
Public.

Description

Add DEPS file disallowing content/public to depend back to content/. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114217

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove redundant comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
A content/public/DEPS View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jói
Note that this is independent of the discussion I started about concrete classes in content/public. ...
9 years ago (2011-12-13 14:05:39 UTC) #1
jam
lgtm with nit http://codereview.chromium.org/8890075/diff/1/content/public/DEPS File content/public/DEPS (right): http://codereview.chromium.org/8890075/diff/1/content/public/DEPS#newcode1 content/public/DEPS:1: # Do NOT add chrome to ...
9 years ago (2011-12-13 14:47:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/8890075/2002
9 years ago (2011-12-13 14:51:39 UTC) #3
Jói
Removed the redundant comment and uploaded a new patch. Will commit via CQ. On Tue, ...
9 years ago (2011-12-13 14:51:50 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-13 16:01:59 UTC) #5
Change committed as 114217

Powered by Google App Engine
This is Rietveld 408576698