Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 8890074: Add test Origin Bound Certificate data for http://codereview.chromium.org/8890073/ (Closed)

Created:
9 years ago by mattm
Modified:
9 years ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, --1 lines) Patch
M net/data/ssl/certificates/README View 2 chunks +5 lines, -1 line 1 comment Download
A net/data/ssl/certificates/unittest.originbound.der View 0 chunks +-1 lines, --1 lines 0 comments Download
A net/data/ssl/certificates/unittest.originbound.key.der View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mattm
9 years ago (2011-12-13 05:26:40 UTC) #1
wtc
LGTM. http://codereview.chromium.org/8890074/diff/2001/net/data/ssl/certificates/README File net/data/ssl/certificates/README (right): http://codereview.chromium.org/8890074/diff/2001/net/data/ssl/certificates/README#newcode44 net/data/ssl/certificates/README:44: - unittest.key.bin : private key stored unencrypted. We ...
9 years ago (2011-12-14 01:37:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/8890074/2001
9 years ago (2011-12-14 21:24:46 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-14 23:16:27 UTC) #4
Change committed as 114525

Powered by Google App Engine
This is Rietveld 408576698