Handle Origin Bound Certificate expiration.

net/base/origin_bound_cert_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_ORIGIN_BOUND_CERT_SERVICE_H_
 #define NET_BASE_ORIGIN_BOUND_CERT_SERVICE_H_
 #pragma once
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/time.h"
 #include "base/threading/non_thread_safe.h"
 #include "net/base/completion_callback.h"
 #include "net/base/net_export.h"
 #include "net/base/ssl_client_cert_type.h"
 
 namespace net {
 
 class OriginBoundCertServiceJob;
 class OriginBoundCertServiceWorker;
 class OriginBoundCertStore;
@@ skipping 62 matching lines @@
 
   // On success, |private_key| stores a DER-encoded PrivateKeyInfo
   // struct, and |cert| stores a DER-encoded certificate. Returns
   // OK if successful and an error code otherwise.
   // |serial_number| is passed in because it is created with the function
   // base::RandInt, which opens the file /dev/urandom. /dev/urandom is opened
   // with a LazyInstance, which is not allowed on a worker thread.
   static int GenerateCert(const std::string& origin,
                           SSLClientCertType type,
                           uint32 serial_number,
+                          base::Time not_valid_after,

[wtc, 2011/12/14 02:03:39]

Please document the |type| and |not_valid_after| input
parameters.

For the GenerateCert() method, it may be better to take
a base::TimeDelta validity_period input parameter instead.

[mattm, 2011/12/20 00:28:38]

I documented the expiration_time return value.  I think that like origin, the
type input is pretty self-explanitory.

                           std::string* private_key,
                           std::string* cert);
 
   void HandleResult(const std::string& origin,
                     int error,
                     SSLClientCertType type,
+                    base::Time not_valid_after,
                     const std::string& private_key,
                     const std::string& cert);
 
   scoped_ptr<OriginBoundCertStore> origin_bound_cert_store_;
 
   // inflight_ maps from an origin to an active generation which is taking
   // place.
   std::map<std::string, OriginBoundCertServiceJob*> inflight_;
 
   uint64 requests_;
   uint64 cert_store_hits_;
   uint64 inflight_joins_;
 
   DISALLOW_COPY_AND_ASSIGN(OriginBoundCertService);
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_ORIGIN_BOUND_CERT_SERVICE_H_