Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 8890067: Remove #ifdef OFFICIAL_BUILD from scoped variant unittest, as the code is now always compiled (Closed)

Created:
9 years ago by jochen (gone - plz use gerrit)
Modified:
9 years ago
Reviewers:
brettw
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove #ifdef OFFICIAL_BUILD from scoped variant unittest, as the code is now always compiled BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113944

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/win/scoped_variant_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
9 years ago (2011-12-09 11:10:55 UTC) #1
brettw
lgtm
9 years ago (2011-12-09 23:54:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8890067/1
9 years ago (2011-12-10 07:54:17 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-10 09:08:13 UTC) #4
Change committed as 113944

Powered by Google App Engine
This is Rietveld 408576698