Issue 8890058: Disable PPAPITest.Fullscreen on Chrome OS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8890058: Disable PPAPITest.Fullscreen on Chrome OS. (Closed)

Created:
9 years ago by bbudge

Modified:
9 years ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Disable PPAPITest.Fullscreen on Chrome OS. TBR=cbentzel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113725

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/test/ui/ppapi_uitest.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

http://codereview.chromium.org/8890058/diff/1/chrome/test/ui/ppapi_uitest.cc File chrome/test/ui/ppapi_uitest.cc (right): http://codereview.chromium.org/8890058/diff/1/chrome/test/ui/ppapi_uitest.cc#newcode518 chrome/test/ui/ppapi_uitest.cc:518: // Fullscreen test fails on Mac. 1. Comment is ...

9 years ago (2011-12-09 01:49:22 UTC) #1

bbudge-google

9 years ago (2011-12-09 02:38:53 UTC) #2

On 2011/12/09 01:49:22, sergeyu wrote:
> http://codereview.chromium.org/8890058/diff/1/chrome/test/ui/ppapi_uitest.cc
> File chrome/test/ui/ppapi_uitest.cc (right):
> 
>
http://codereview.chromium.org/8890058/diff/1/chrome/test/ui/ppapi_uitest.cc#...
> chrome/test/ui/ppapi_uitest.cc:518: // Fullscreen test fails on Mac.
> 1. Comment is not correct now.
> 2. Is there a bug for this issue?

I will add a bug. I'm working actively on this test on the failing platforms and
should follow up in the next day or so.

Expand Messages | Collapse Messages