linux: Remove all 40 static initializers from escape.cc.

linux: Remove all 40 static initializers from escape.cc.

gcc 4.4.3 isn't very bright.

BUG=94925
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113757

[eroman, 2011-12-09 00:59:33]

lgtm

[Peter Kasting, 2011-12-09 01:00:43]

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc
File net/base/escape.cc (right):

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc#newcode36
net/base/escape.cc:36: uint32 map_[8];
Nit: Shouldn't this become |map| now?

[commit-bot: I haz the power, 2011-12-09 01:01:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8890055/1

[Nico, 2011-12-09 01:08:25]

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc
File net/base/escape.cc (right):

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc#newcode36
net/base/escape.cc:36: uint32 map_[8];
On 2011/12/09 01:00:43, Peter Kasting wrote:
> Nit: Shouldn't this become |map| now?

Dunno, does our style guide say that? I thought I saw several structs with _ on
their members.

[Peter Kasting, 2011-12-09 01:55:21]

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc
File net/base/escape.cc (right):

http://codereview.chromium.org/8890055/diff/1/net/base/escape.cc#newcode36
net/base/escape.cc:36: uint32 map_[8];
On 2011/12/09 01:08:25, Nico wrote:
> On 2011/12/09 01:00:43, Peter Kasting wrote:
> > Nit: Shouldn't this become |map| now?
> 
> Dunno, does our style guide say that? I thought I saw several structs with _
on
> their members.

From the Google C++ style guide:

"Data members in structs should be named like regular variables without the
trailing underscores that data members in classes have."

[Nico, 2011-12-09 02:02:02]

done

[commit-bot: I haz the power, 2011-12-09 02:17:15]

Try job failure for 8890055-1 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-09 02:17:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8890055/2003

[commit-bot: I haz the power, 2011-12-09 02:59:12]

Try job failure for 8890055-2003 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-09 03:08:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8890055/2003