Adding metrics to track browser launches per primary/secondary profile. Adding metrics to track n...

chrome/browser/profiles/profile_metrics.h

Index: chrome/browser/profiles/profile_metrics.h
===================================================================
--- chrome/browser/profiles/profile_metrics.h	(revision 113419)
+++ chrome/browser/profiles/profile_metrics.h	(working copy)
@@ -11,6 +11,7 @@
 #include "base/basictypes.h"
 
 class FilePath;
+class ProfileManager;
 
 class ProfileMetrics {
  public:
@@ -61,15 +62,27 @@
     NUM_PROFILE_GAIA_METRICS
   };
 
+  enum ProfileEvent {
+    STARTUP_PROFILE_EVENT = 0,
+    ADD_PROFILE_EVENT,
+    DELETE_PROFILE_EVENT
+  };
+
+  static void LogNumberOfProfiles(ProfileManager* manager,
+                                  ProfileEvent startup);
+  static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
+  static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
-  static void LogProfileAddNewUser(ProfileAdd metric);
+  static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
-  static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileSyncInfo(ProfileSync metric);
-  static void LogProfileUpdate(FilePath& profile_path);
-  static void LogProfileSyncSignIn(FilePath& profile_path);
-  static void LogProfileSwitchGaia(ProfileGaia metric);
+
+  // These functions should only be called on the UI thread because they hook
+  // into g_browser_process through a helper function.

[jar (doing other things), 2011/12/10 22:07:44]

If it was worth commenting... it is probably worth adding a DCHECK() in the
method as well.

[rpetterson, 2011/12/11 08:46:12]

There is already one there. See line 20 of profile_metrics.cc.

+  static void LogProfileLaunch(const FilePath& profile_path);
+  static void LogProfileSyncSignIn(const FilePath& profile_path);
+  static void LogProfileUpdate(const FilePath& profile_path);
 };