Adding metrics to track browser launches per primary/secondary profile. Adding metrics to track n...

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
@@ skipping 43 matching lines @@
     SECONDARY,            // Refers to a user-created profile
     NUM_PROFILE_TYPE_METRICS
   };
 
   enum ProfileGaia {
     GAIA_OPT_IN = 0,           // User changed to GAIA photo as avatar
     GAIA_OPT_OUT,              // User changed to not use GAIA photo as avatar
     NUM_PROFILE_GAIA_METRICS
   };
 
+  enum ProfileTime {

[jar (doing other things), 2011/12/09 04:57:13]

I'm confused by the name here.  This has nothing to do with "Time" but yet your
are naming it that way.

Can you motivate the use of the word, or suggest a better name?

Maybe the enum should be called ProfileEvents, or ProfileHandlingEvents.

Maybe the enums should be something like:
STARTUP_PROFILE_EVENT
ADD_PROFILE_EVENT
DELETE_PROFILE_EVENT

[Miranda Callahan, 2011/12/09 14:01:02]

Ditto -- I vote for "ProfileEvents", and the enum names jar listed here.

[rpetterson, 2011/12/09 21:22:09]

Yes, thanks, jar. These make a lot more sense are potentially more useful in the
future as well. Fixed.

+    TIME_STARTUP = 0,
+    TIME_ADD,
+    TIME_DELETE
+  };
+
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileOpenMethod(ProfileOpen metric);
   static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
   static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileUpdate(FilePath& profile_path);
   static void LogProfileSyncSignIn(FilePath& profile_path);
   static void LogProfileSwitchGaia(ProfileGaia metric);
+  static void LogProfileLaunch(FilePath& profile_path);
+  static void LogNumberOfProfiles(ProfileTime startup);

[Miranda Callahan, 2011/12/09 14:01:02]

Maybe this list should be in alpha-order so they're easy to find quickly, and
because I have OCD? ;-)

[rpetterson, 2011/12/09 21:22:09]

:) All set. And rearranged to match in the .cc file so the definitions are easy
to find as well.  Except for the three FilePath functions which are pulled out
for their comment.

 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_