Adding metrics to track browser launches per primary/secondary profile. Adding metrics to track n...

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 13 matching lines @@
     user_data_dir = manager->user_data_dir();
   }
   if (profile_path == user_data_dir.AppendASCII(chrome::kInitialProfile)) {
     metric = ProfileMetrics::ORIGINAL;
   }
   return metric;
 }
 
 }  // namespace
 
+// Anything above 20 is lumped together as one metric.
+const size_t kMaxNumberOfProfilesTracked = 21;
+
 enum ProfileAvatar {
   AVATAR_GENERIC = 0,       // The names for avatar icons
   AVATAR_GENERIC_AQUA,
   AVATAR_GENERIC_BLUE,
   AVATAR_GENERIC_GREEN,
   AVATAR_GENERIC_ORANGE,
   AVATAR_GENERIC_PURPLE,
   AVATAR_GENERIC_RED,
   AVATAR_GENERIC_YELLOW,
   AVATAR_SECRET_AGENT,
@@ skipping 156 matching lines @@
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileSwitchGaia(ProfileGaia metric) {
   if (metric == GAIA_OPT_IN)
     LogProfileAvatarSelection(AVATAR_GAIA);
   UMA_HISTOGRAM_ENUMERATION("Profile.SwitchGaiaPhotoSettings",
                             metric,
                             NUM_PROFILE_GAIA_METRICS);
 }
+
+void ProfileMetrics::LogProfileLaunch(FilePath& profile_path) {
+  UMA_HISTOGRAM_ENUMERATION("Profile.LaunchBrowser",
+                            GetProfileType(profile_path),
+                            NUM_PROFILE_TYPE_METRICS);
+}
+
+void ProfileMetrics::LogNumberOfProfiles(bool startup) {
+  ProfileManager* manager = g_browser_process->profile_manager();
+  size_t number_of_profiles =
+      manager->GetProfileInfoCache().GetNumberOfProfiles();
+  if (number_of_profiles > kMaxNumberOfProfilesTracked)
+    number_of_profiles = kMaxNumberOfProfilesTracked;

[Ilya Sherman, 2011/12/09 00:53:41]

There shouldn't be any need to do this -- the last histogram bucket will also
serve as an overflow bucket.

[rpetterson, 2011/12/09 01:44:35]

Cool. Done.

+  if (startup) {
+    UMA_HISTOGRAM_ENUMERATION("Profile.NumberOfProfilesOnStartup",
+                              number_of_profiles,
+                              NUM_PROFILE_TYPE_METRICS);

[Ilya Sherman, 2011/12/09 00:53:41]

I think you want UMA_HISTOGRAM_COUNTS_100 (or something like it), rather than
UMA_HISTOGRAM_ENUMERATION here.

[rpetterson, 2011/12/09 01:44:35]

Done.

+  } else {
+    UMA_HISTOGRAM_ENUMERATION("Profile.NumberOfProfilesOnAddDelete",

[Ilya Sherman, 2011/12/09 00:53:41]

ditto

[rpetterson, 2011/12/09 01:44:35]

Done.

+                              number_of_profiles,
+                              NUM_PROFILE_TYPE_METRICS);
+  }
+}