Adding metrics to track browser launches per primary/secondary profile. Adding metrics to track n...

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
 #include <string>
 
 #include "base/basictypes.h"
 
 class FilePath;
+class ProfileManager;
 
 class ProfileMetrics {
  public:
   // Enum for counting the ways users were added.
   enum ProfileAdd {
     ADD_NEW_USER_ICON = 0,    // User adds new user from icon menu
     ADD_NEW_USER_MENU,        // User adds new user from menu bar
     NUM_PROFILE_ADD_METRICS
   };
 
@@ skipping 30 matching lines @@
     SECONDARY,            // Refers to a user-created profile
     NUM_PROFILE_TYPE_METRICS
   };
 
   enum ProfileGaia {
     GAIA_OPT_IN = 0,           // User changed to GAIA photo as avatar
     GAIA_OPT_OUT,              // User changed to not use GAIA photo as avatar
     NUM_PROFILE_GAIA_METRICS
   };
 
+  enum ProfileEvent {
+    STARTUP_PROFILE_EVENT = 0,
+    ADD_PROFILE_EVENT,
+    DELETE_PROFILE_EVENT
+  };
+
+  static void LogNumberOfProfiles(ProfileManager* manager,
+                                  ProfileEvent startup);
+  static void LogProfileAddNewUser(ProfileAdd metric);
   static void LogProfileAvatarSelection(size_t icon_index);
+  static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileOpenMethod(ProfileOpen metric);
-  static void LogProfileAddNewUser(ProfileAdd metric);
+  static void LogProfileSwitchGaia(ProfileGaia metric);
   static void LogProfileSwitchUser(ProfileOpen metric);
-  static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileSyncInfo(ProfileSync metric);
-  static void LogProfileUpdate(FilePath& profile_path);
-  static void LogProfileSyncSignIn(FilePath& profile_path);
-  static void LogProfileSwitchGaia(ProfileGaia metric);
+
+  // These functions should only be called on the UI thread because they hook
+  // into g_browser_process through a helper function.

[jar (doing other things), 2011/12/10 22:07:44]

If it was worth commenting... it is probably worth adding a DCHECK() in the
method as well.

[rpetterson, 2011/12/11 08:46:12]

There is already one there. See line 20 of profile_metrics.cc.

+  static void LogProfileLaunch(const FilePath& profile_path);
+  static void LogProfileSyncSignIn(const FilePath& profile_path);
+  static void LogProfileUpdate(const FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_