Issue 8890050: Attempt 3 at:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8890050: Attempt 3 at: (Closed)

Created:
9 years ago by sky

Modified:
9 years ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Ian Vollick, dhollowa+watch_chromium.org, jonathan.backer, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., piman+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Attempt 3 at: Makes tests either use mock compositor or mock WebGraphicsContext3D depending upon which compositor we're running. This is needed to enable ui tests on the bots. Attempt 2 failed because of last minute changes to chrome_tests.gypi that I didn't merge properly with. TBRing again. BUG=104360 TEST=none TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113809

Patch Set 1 #

Patch Set 2 : Da fix #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -35 lines)			Patch
M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_extra_parts_aura.cc	View		2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/test/base/chrome_test_suite.cc	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/test/ui/ui_test.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	content/test/content_test_suite.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	ui/aura/aura.gyp	View		4 chunks	+16 lines, -2 lines	0 comments	Download
M	ui/aura/test/test_suite.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	ui/aura_shell/aura_shell.gyp	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	ui/aura_shell/test_suite.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor.gyp	View		4 chunks	+7 lines, -1 line	0 comments	Download
M	ui/gfx/compositor/compositor_cc.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/gfx/compositor/compositor_cc.cc	View		5 chunks	+17 lines, -10 lines	0 comments	Download
A	ui/gfx/compositor/compositor_setup.h	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor_switches.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/layer_unittest.cc	View		5 chunks	+18 lines, -6 lines	0 comments	Download
M	ui/views/run_all_unittests.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	ui/views/view_unittest.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/views/views.gyp	View		2 chunks	+9 lines, -1 line	0 comments	Download