GTK: Remove deprecated drawing call and replace them with cairo.

GTK: Remove deprecated drawing call and replace them with cairo.

gdk_pixbuf_render_to_drawable has been deprecated since libgtk 2.4 and
won't be in libgtk3 at all.

BUG=106060
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113733

[James Hawkins, 2011-12-08 23:37:31]

http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):

http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:785: drop_indicator_width =
gdk_pixbuf_get_width(drop_image);
Can we get these values from the returned gfx::Image?

[Elliot Glaysher, 2011-12-08 23:39:59]

http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):

http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:785: drop_indicator_width =
gdk_pixbuf_get_width(drop_image);
On 2011/12/08 23:37:31, James Hawkins wrote:
> Can we get these values from the returned gfx::Image?

Nope! Because a gfx::Image can have multiple representations at different sizes.
This is used on the mac for the high resolution icons.

[James Hawkins, 2011-12-08 23:42:02]

On 2011/12/08 23:39:59, Elliot Glaysher wrote:
>
http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right):
> 
>
http://codereview.chromium.org/8890048/diff/1/chrome/browser/ui/gtk/tabs/tab_...
> chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:785: drop_indicator_width =
> gdk_pixbuf_get_width(drop_image);
> On 2011/12/08 23:37:31, James Hawkins wrote:
> > Can we get these values from the returned gfx::Image?
> 
> Nope! Because a gfx::Image can have multiple representations at different
sizes.
> This is used on the mac for the high resolution icons.

Interesting. LGTM

[commit-bot: I haz the power, 2011-12-08 23:44:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8890048/1

[commit-bot: I haz the power, 2011-12-09 01:50:59]

Change committed as 113733