Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 8890043: Filter -fstack-protector out of cflags for nacl_helper_bootstrap (Closed)

Created:
9 years ago by Roland McGrath
Modified:
9 years ago
Reviewers:
noelallen1, bradn
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Filter -fstack-protector out of cflags for nacl_helper_bootstrap Some Linux distributions want to build Chromium with GYP_DEFINES="release_extra_cflags='-mthis -fstack-protector -mthat'". This breaks the build of nacl_helper_bootstrap because we need to ensure that -fstack-protector is never used for that file. Filtering out the potentially incompatible options fixes this scenario. BUG= http://code.google.com/p/chromium/issues/detail?id=104569 TEST= manually tested in chromium build with conflicting release_extra_cflags setting R=noelallen@chromium.org Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=7417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/trusted/service_runtime/linux/nacl_bootstrap.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
9 years ago (2011-12-08 22:41:46 UTC) #1
Roland McGrath
PTAL
9 years ago (2011-12-13 00:07:54 UTC) #2
bradn
9 years ago (2011-12-13 00:11:41 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698