Share X connection between GLSurfaceGLX/EGL and MessagePumpX/GTK

Share X connection between GLSurfaceGLX/EGL and MessagePumpX/GTK

BUG=104248
TEST=chrome: about:gpu and webgl pages (both aura and gtk), compositor_unittests, views_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113858

[piman, 2011-12-08 22:42:03]

It wasn't nearly as bad as I thought...

[piman, 2011-12-08 22:42:59]

+apatrick for OWNERS

[jonathan.backer, 2011-12-08 22:46:57]

On 2011/12/08 22:42:59, piman wrote:
> +apatrick for OWNERS

My bad I should have marked the bug as started:
http://codereview.chromium.org/8873018/ is in the CQ.

[jonathan.backer, 2011-12-08 22:53:02]

On 2011/12/08 22:46:57, jonathan.backer wrote:
> On 2011/12/08 22:42:59, piman wrote:
> > +apatrick for OWNERS
> 
> My bad I should have marked the bug as started:
> http://codereview.chromium.org/8873018/ is in the CQ.

Your patch seems a bit more thorough (changes to gpu_main.cc). I've unclicked
the CQ button (hopefully that cancels it). Feel free to land this instead.

[piman, 2011-12-08 23:02:22]

On Thu, Dec 8, 2011 at 2:53 PM, <backer@chromium.org> wrote:

> On 2011/12/08 22:46:57, jonathan.backer wrote:
>
>> On 2011/12/08 22:42:59, piman wrote:
>> > +apatrick for OWNERS
>>
>
>  My bad I should have marked the bug as started:
>>
http://codereview.chromium.**org/8873018/<http://codereview.chromium.org/8873...
in the CQ.
>>
>
> Your patch seems a bit more thorough (changes to gpu_main.cc). I've
> unclicked
> the CQ button (hopefully that cancels it). Feel free to land this instead.
>

Ok. You CL cleaned up more stuff which is nice, but the changes to gpu_main
are needed on non-aura linux.

I'll still need an OWNERS lgtm.

Antoine

>
>
http://codereview.chromium.**org/8890042/<http://codereview.chromium.org/8890...
>

[apatrick_chromium, 2011-12-09 00:31:07]

lgtm

[commit-bot: I haz the power, 2011-12-09 02:02:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/8890042/7

[commit-bot: I haz the power, 2011-12-09 02:02:36]

Presubmit check for 8890042-7 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: base/message_pump_x.cc

Presubmit checks took 1.2s to calculate.

[piman, 2011-12-09 02:11:04]

+darin for OWNERS in base/

[darin (slow to review), 2011-12-09 17:43:56]

base/ -> LGTM

[commit-bot: I haz the power, 2011-12-09 17:49:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/8890042/7

[commit-bot: I haz the power, 2011-12-09 22:15:22]

Change committed as 113858