Aura: Separate constrained window and translucent frame flags

Aura: Separate window dragging and translucent frame flags

Split --aura-windows into --aura-workspace-manager and --aura-translucent-frames.
Also fixed a bug where the window frame was still opaque despite the latter flag.

BUG=106890
TEST=manual, run with all combinations of above flags


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113921

[James Cook, 2011-12-08 21:11:03]

Oshima, PTAL.

[oshima, 2011-12-08 21:57:03]

http://codereview.chromium.org/8890036/diff/1/ui/aura/aura_switches.h
File ui/aura/aura_switches.h (right):

http://codereview.chromium.org/8890036/diff/1/ui/aura/aura_switches.h#newcode13
ui/aura/aura_switches.h:13: AURA_EXPORT extern const char
kAuraConstrainedWindows[];
There is ConstrainedWindow and may cause some confusion. How about
kAuraWorkspaceManager?

[James Cook, 2011-12-08 22:35:24]

http://codereview.chromium.org/8890036/diff/1/ui/aura/aura_switches.h
File ui/aura/aura_switches.h (right):

http://codereview.chromium.org/8890036/diff/1/ui/aura/aura_switches.h#newcode13
ui/aura/aura_switches.h:13: AURA_EXPORT extern const char
kAuraConstrainedWindows[];
On 2011/12/08 21:57:03, oshima wrote:
> There is ConstrainedWindow and may cause some confusion. How about
> kAuraWorkspaceManager?

Yes, that's better.  Done.

[oshima, 2011-12-08 23:15:36]

LGTM

http://codereview.chromium.org/8890036/diff/4001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/8890036/diff/4001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4961: Enable smart window sizing and
dragging, which attempts to maximize the use of screen space.
Enable multiple workspace, smart window resizing ...

[commit-bot: I haz the power, 2011-12-09 01:16:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/8890036/6001

[commit-bot: I haz the power, 2011-12-09 01:16:42]

Presubmit check for 8890036-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/aura/aura_switches.cc,ui/aura/aura_switches.h,ui/aura_shell/shell.cc

Presubmit checks took 1.7s to calculate.

[James Cook, 2011-12-09 16:16:21]

Scott, can I get OWNERS approval for the ui/aura and ui/aura_shell changes?  I'm
splitting a flag in two.

[sky, 2011-12-09 18:03:16]

LGTM

[commit-bot: I haz the power, 2011-12-09 18:05:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/8890036/6001

[commit-bot: I haz the power, 2011-12-09 20:07:06]

Try job failure for 8890036-6001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-12-09 20:20:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/8890036/6001

[commit-bot: I haz the power, 2011-12-09 22:40:10]

Try job failure for 8890036-6001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-12-09 23:57:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/8890036/6001

[commit-bot: I haz the power, 2011-12-10 01:55:33]

Change committed as 113921