Issue 8890034: Turn on use_skia by default for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8890034: Turn on use_skia by default for Mac (Closed)

Created:
9 years ago by epoger

Modified:
9 years ago

Reviewers:
reed1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Turn on use_skia by default for Mac BUG=101731 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113807

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/use_skia_on_mac.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

9 years ago (2011-12-09 15:01:14 UTC) #3

On 2011/12/08 21:08:12, reed1 wrote:
> lgtm

Mac trybot is failing, but that's because the trybot is apparently building
against an old version of chrome/renderer/print_web_view_helper_mac.mm . 
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_vie...
verifies that I updated that file 20 hours ago, and it has not been reverted
since then...

The waterfall bots may need a clobber to pick up the new use_skia value anyway,
so I'm going to go ahead and commit this change.

Expand Messages | Collapse Messages