Issue 889003: Propagate reaching definitions to the instuctions of a block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 889003: Propagate reaching definitions to the instuctions of a block. (Closed)

Created:
10 years, 9 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Propagate reaching definitions to the instuctions of a block. After computing RD_in for all flow graph nodes, push the reaching definitions through the basic blocks to annotate all variable references in the AST. Committed: http://code.google.com/p/v8/source/detail?r=4143

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+162 lines, -61 lines)
M	src/ast.h	View	3 chunks	+5 lines, -0 lines	0 comments
M	src/ast.cc	View	1 chunk	+4 lines, -2 lines	0 comments
M	src/data-flow.h	View	3 chunks	+6 lines, -0 lines	0 comments
M	src/data-flow.cc	View	18 chunks	+147 lines, -59 lines	1 comment

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

10 years, 9 months ago (2010-03-15 10:11:15 UTC) #2

LGTM otherwise.

http://codereview.chromium.org/889003/diff/1/4
File src/data-flow.cc (right):

http://codereview.chromium.org/889003/diff/1/4#newcode2128
src/data-flow.cc:2128: }
Misplaced brackets?

Expand Messages | Collapse Messages