Issue 8890027: GTK: Remove most calls to widget->window and replace with accessor.

Issue 8890027: GTK: Remove most calls to widget->window and replace with accessor. (Closed)

Created:
9 years ago by Elliot Glaysher

Modified:
9 years ago

Reviewers:
prasadt

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

GTK: Remove most calls to widget->window and replace with accessor. BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113687

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -65 lines)			Patch
M	chrome/browser/ui/gtk/bubble/bubble_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/bubble/bubble_gtk.cc	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View	2 chunks	+2 lines, -42 lines	1 comment	Download
M	chrome/browser/ui/panels/panel_browser_window_gtk.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/window_snapshot/window_snapshot_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Elliot Glaysher

(Quick context: GTK3 removes raw struct access to almost all widget->blah members, instead forcing you ...

9 years ago (2011-12-08 19:24:53 UTC) #1

prasadt

lgtm On 2011/12/08 19:24:53, Elliot Glaysher wrote: > (Quick context: GTK3 removes raw struct access ...

9 years ago (2011-12-08 21:18:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8890027/1

9 years ago (2011-12-08 21:20:59 UTC) #3

Change committed as 113687