Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Unified Diff: chrome/test/webdriver/commands/create_session.cc

Issue 8890026: Allow chromedriver to set local state preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/create_session.cc
diff --git a/chrome/test/webdriver/commands/create_session.cc b/chrome/test/webdriver/commands/create_session.cc
index f78fa382d2a988bedc20bf36c32ffa7c614e6d1f..29e1ee974ab6d7f85542a441cce851c64147b03b 100644
--- a/chrome/test/webdriver/commands/create_session.cc
+++ b/chrome/test/webdriver/commands/create_session.cc
@@ -57,12 +57,15 @@ void CreateSession::ExecutePost(Response* const response) {
Session::Options session_options;
session_options.load_async = caps.load_async;
session_options.use_native_events = caps.native_events;
+ session_options.no_website_testing_defaults =
+ caps.no_website_testing_defaults;
Automation::BrowserOptions browser_options;
browser_options.command = caps.command;
browser_options.channel_id = caps.channel;
browser_options.detach_process = caps.detach;
browser_options.user_data_dir = caps.profile;
+ browser_options.cert_revocation_checking = caps.cert_revocation_checking;
// Session manages its own liftime, so do not call delete.
Session* session = new Session(session_options);
@@ -72,15 +75,6 @@ void CreateSession::ExecutePost(Response* const response) {
return;
}
- // Install extensions.
- for (size_t i = 0; i < caps.extensions.size(); ++i) {
- Error* error = session->InstallExtensionDeprecated(caps.extensions[i]);
- if (error) {
- response->SetError(error);
- return;
- }
- }
-
LOG(INFO) << "Created session " << session->id();
// Redirect to a relative URI. Although prohibited by the HTTP standard,
// this is what the IEDriver does. Finding the actual IP address is

Powered by Google App Engine
This is Rietveld 408576698