Allow chromedriver to set local state preferences.

Change chromedriver to set geolocation/notification content setting defaults to allow.
Also disable cert revocation checking.
These changes can be overruled by setting the noWebsiteTestingDefaults capability.
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114026

[kkania, 2011-12-09 22:50:46]

ping?

[Huyen, 2011-12-09 23:56:55]

http://codereview.chromium.org/8890026/diff/3015/chrome/test/pyautolib/chrome...
File chrome/test/pyautolib/chrome_driver_factory.py (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/pyautolib/chrome...
chrome/test/pyautolib/chrome_driver_factory.py:45:
'chrome.useWebsiteTestingDefaults': False})
did you mean "chrome.noWebsiteTestingDefaults"?

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:752: *error = CompareVersion(927,
0, &has_new_local_state_api);
maybe move the version # out into a constant and/or add comment stating this
version supports new local state api

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:781: *error = CompareVersion(964,
0, &has_new_pref_api);
same comment as above

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_capabilities_parser.cc (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_capabilities_parser.cc:150: Error*
CapabilitiesParser::ParseCertRevocationChecking(
did you forget to map this function to the parser_map? i don't see an entry for
it in the constructor.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_capabilities_parser.h (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_capabilities_parser.h:59: // If true,
ChromeDriver will bypass certain configuration options that
same comment as in webdriver_session.h.
Maybe reorder the wording a little bit: "By default ChromeDriver configures
Chrome so that websites...infobar. If this flag is true, ChromeDriver will not
make these configurations."

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_session.h (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_session.h:64: // If true, ChromeDriver will
bypass certain configuration options that
Maybe reorder the wording a little bit:
"By default ChromeDriver configures Chrome so that websites...infobar. If this
flag is true, ChromeDriver will not make these configurations."

[kkania, 2011-12-10 00:37:44]

http://codereview.chromium.org/8890026/diff/3015/chrome/test/pyautolib/chrome...
File chrome/test/pyautolib/chrome_driver_factory.py (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/pyautolib/chrome...
chrome/test/pyautolib/chrome_driver_factory.py:45:
'chrome.useWebsiteTestingDefaults': False})
On 2011/12/09 23:56:55, Huyen wrote:
> did you mean "chrome.noWebsiteTestingDefaults"?

Done.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_automation.cc (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:752: *error = CompareVersion(927,
0, &has_new_local_state_api);
On 2011/12/09 23:56:55, Huyen wrote:
> maybe move the version # out into a constant and/or add comment stating this
> version supports new local state api

Done.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_automation.cc:781: *error = CompareVersion(964,
0, &has_new_pref_api);
On 2011/12/09 23:56:55, Huyen wrote:
> same comment as above

Done.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_capabilities_parser.cc (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_capabilities_parser.cc:150: Error*
CapabilitiesParser::ParseCertRevocationChecking(
On 2011/12/09 23:56:55, Huyen wrote:
> did you forget to map this function to the parser_map? i don't see an entry
for
> it in the constructor.

Forgot to delete this. I decided I didn't like this idea.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_capabilities_parser.h (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_capabilities_parser.h:59: // If true,
ChromeDriver will bypass certain configuration options that
On 2011/12/09 23:56:55, Huyen wrote:
> same comment as in webdriver_session.h.
> Maybe reorder the wording a little bit: "By default ChromeDriver configures
> Chrome so that websites...infobar. If this flag is true, ChromeDriver will not
> make these configurations." 

Done.

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
File chrome/test/webdriver/webdriver_session.h (right):

http://codereview.chromium.org/8890026/diff/3015/chrome/test/webdriver/webdri...
chrome/test/webdriver/webdriver_session.h:64: // If true, ChromeDriver will
bypass certain configuration options that
On 2011/12/09 23:56:55, Huyen wrote:
> Maybe reorder the wording a little bit:
> "By default ChromeDriver configures Chrome so that websites...infobar. If this
> flag is true, ChromeDriver will not make these configurations."
> 

Done.

[Huyen, 2011-12-10 00:54:23]

lgtm