Issue 8890023: win_release_OmitFramePointers=0 must explicitly pass /Oy-

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8890023: win_release_OmitFramePointers=0 must explicitly pass /Oy- (Closed)

Created:
9 years ago by Derek Bruening

Modified:
9 years ago

Reviewers:
Timur Iskhodzhanov, M-A Ruel

CC:
chromium-reviews, kareng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

win_release_OmitFramePointers=0 must explicitly pass /Oy- since /O2 implies /Oy BUG=106711 TEST=examined All.vcproj and ./build/Release/obj/googleurl_unittests/BuildLog.htm and confirmed /Oy- is present Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113657

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruening@chromium.org/8890023/1

9 years ago (2011-12-08 19:25:08 UTC) #4

M-A Ruel

9 years ago (2011-12-13 18:19:29 UTC) #6

On 2011/12/08 21:04:15, I haz the power (commit-bot) wrote:
> Change committed as 113657

FYI, we are backing out this CL from 970 to see if it helps with LTCG build.

Expand Messages | Collapse Messages