Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8890022: Remove Hunspell on OS X - step 2 (Closed)

Created:
9 years ago by jeremy
Modified:
9 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, ajwong+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove Hunspell on OS X - step 2 * Remove empty Linux & Win implementations of the class. * Rename files and unit test to be Mac only. * Rename namespace SpellCheckerPlatform -> SpellCheckerMac * Surround usage in crossplatform files with #ifdef OS_MACOSX as a temporary measure (a future step will be to remove the calls entirely from these files). BUG=69944 TEST=Spelling correction feature should continue to work as expected on Mac/Win/Linux . Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113974

Patch Set 1 #

Patch Set 2 : Rename unit tests #

Total comments: 4

Patch Set 3 : Fix review comments. #

Total comments: 2

Patch Set 4 : Fix namespace name #

Total comments: 1

Patch Set 5 : Fix rename in unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -922 lines) Patch
M chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_impl.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 2 3 3 chunks +22 lines, -8 lines 0 comments Download
A + chrome/browser/spellchecker/spellcheck_platform_mac.h View 1 2 4 chunks +5 lines, -9 lines 0 comments Download
A + chrome/browser/spellchecker/spellcheck_platform_mac.mm View 1 2 3 4 chunks +4 lines, -8 lines 0 comments Download
A + chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_linux.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/spellchecker/spellchecker_mac.mm View 1 2 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_platform_engine.h View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_platform_engine_unittest.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D chrome/browser/spellchecker/spellchecker_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/tab_contents/spellchecker_submenu_observer_mac.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/spelling_menu_observer.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jeremy
9 years ago (2011-12-08 18:22:28 UTC) #1
Robert Sesek
http://codereview.chromium.org/8890022/diff/2001/chrome/browser/spellchecker/spellcheck_host_impl.cc File chrome/browser/spellchecker/spellcheck_host_impl.cc (right): http://codereview.chromium.org/8890022/diff/2001/chrome/browser/spellchecker/spellcheck_host_impl.cc#newcode20 chrome/browser/spellchecker/spellcheck_host_impl.cc:20: #include "chrome/browser/spellchecker/spellchecker_mac.h" This was in the correct location (spellchecker ...
9 years ago (2011-12-08 18:54:33 UTC) #2
jeremy
All done, ready for another look. http://codereview.chromium.org/8890022/diff/2001/chrome/browser/spellchecker/spellcheck_message_filter.cc File chrome/browser/spellchecker/spellcheck_message_filter.cc (right): http://codereview.chromium.org/8890022/diff/2001/chrome/browser/spellchecker/spellcheck_message_filter.cc#newcode57 chrome/browser/spellchecker/spellcheck_message_filter.cc:57: void SpellCheckMessageFilter::OnPlatformCheckSpelling(const string16& ...
9 years ago (2011-12-08 19:18:46 UTC) #3
Robert Sesek
http://codereview.chromium.org/8890022/diff/5002/chrome/browser/spellchecker/spellcheck_platform_mac.mm File chrome/browser/spellchecker/spellcheck_platform_mac.mm (right): http://codereview.chromium.org/8890022/diff/5002/chrome/browser/spellchecker/spellcheck_platform_mac.mm#newcode151 chrome/browser/spellchecker/spellcheck_platform_mac.mm:151: namespace SpellCheckerMac { missed this one http://codereview.chromium.org/8890022/diff/5002/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc File chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc ...
9 years ago (2011-12-08 19:24:40 UTC) #4
jeremy
lgty otherwise?
9 years ago (2011-12-08 19:26:47 UTC) #5
Robert Sesek
lgtm http://codereview.chromium.org/8890022/diff/11002/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc File chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc (right): http://codereview.chromium.org/8890022/diff/11002/chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc#newcode24 chrome/browser/spellchecker/spellcheck_platform_mac_unittest.cc:24: const int doc_tag = SpellCheckerMac::GetDocumentTag(); Missing this one
9 years ago (2011-12-08 20:20:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/8890022/2007
9 years ago (2011-12-11 12:33:25 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-12 03:00:10 UTC) #8 
Change committed as 113974

Powered by Google App Engine
This is Rietveld 408576698