Update Java Bridge to use its own thread in the browser process

content/browser/browser_main_loop.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
 #define CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 68 matching lines @@
   // Members initialized in |InitializeMainThread()| ---------------------------
   // This must get destroyed before other threads that are created in parts_.
   scoped_ptr<BrowserThreadImpl> main_thread_;
   scoped_ptr<BrowserProcessSubThread> db_thread_;
   scoped_ptr<WebKitThread> webkit_thread_;
   scoped_ptr<BrowserProcessSubThread> file_user_blocking_thread_;
   scoped_ptr<BrowserProcessSubThread> file_thread_;
   scoped_ptr<BrowserProcessSubThread> process_launcher_thread_;
   scoped_ptr<BrowserProcessSubThread> cache_thread_;
   scoped_ptr<BrowserProcessSubThread> io_thread_;
+  scoped_ptr<BrowserProcessSubThread> java_bridge_thread_;

[joth, 2011/12/08 18:25:54]

I was wondering whether having a base::Thread owned by
JavaBridgeDispatcherHostManager would be cleaner? This would avoid spilling
knowledge of this fairly constrained use case all over the code, and mean it
could be lazy-created when the JavaBridgeDispatcherHost is created (passing the
MessageLoopProxy in as an extra param) but would mean each tab would get its own
thread, unless there's a sane way to share them. (another LazyInstance....)

Thoughts?

[Steve Block, 2011/12/09 12:39:10]

Yeah, I thought about this, but if we want it to be a BrowserThread, it needs to
be created and destroyed with the other BrowserThreads. I'll have a look at
making it a plain Thread, internal to JavaBridgeDispatcherHost.

 #if defined(OS_CHROMEOS)
   scoped_ptr<BrowserProcessSubThread> web_socket_proxy_thread_;
 #endif
 
   DISALLOW_COPY_AND_ASSIGN(BrowserMainLoop);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BROWSER_MAIN_LOOP_H_