Make source_dependencies in about:net-internals clickable.

chrome/browser/resources/net_internals/source_row.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var SourceRow = (function() {
   'use strict';
 
   /**
    * A SourceRow represents the row corresponding to a single SourceEntry
    * displayed by the EventsView.
@@ skipping 18 matching lines @@
     this.description_ = sourceEntry.getDescription();
 
     this.createRow_();
     this.onSourceUpdated();
   }
 
   SourceRow.prototype = {
     createRow_: function() {
       // Create a row.
       var tr = addNode(this.parentView_.tableBody_, 'tr');
-      tr._id = this.sourceEntry_.getSourceId();
+      tr._id = this.getSourceId();
       tr.style.display = 'none';
       this.row_ = tr;
 
       var selectionCol = addNode(tr, 'td');
       var checkbox = addNode(selectionCol, 'input');
       checkbox.type = 'checkbox';
 
       var idCell = addNode(tr, 'td');
       idCell.style.textAlign = 'right';
 
       var typeCell = addNode(tr, 'td');
       var descriptionCell = addNode(tr, 'td');
       this.descriptionCell_ = descriptionCell;
 
       // Connect listeners.
       checkbox.onchange = this.onCheckboxToggled_.bind(this);
 
       var onclick = this.onClicked_.bind(this);
       idCell.onclick = onclick;
       typeCell.onclick = onclick;
       descriptionCell.onclick = onclick;
 
       tr.onmouseover = this.onMouseover_.bind(this);
       tr.onmouseout = this.onMouseout_.bind(this);
 
       // Set the cell values to match this source's data.
-      if (this.sourceEntry_.getSourceId() >= 0) {
-        addTextNode(idCell, this.sourceEntry_.getSourceId());
+      if (this.getSourceId() >= 0) {
+        addTextNode(idCell, this.getSourceId());
       } else {
         addTextNode(idCell, '-');
       }
       var sourceTypeString = this.sourceEntry_.getSourceTypeString();
       addTextNode(typeCell, sourceTypeString);
       this.updateDescription_();
 
       // Add a CSS classname specific to this source type (so CSS can specify
       // different stylings for different types).
       changeClassName(this.row_, 'source_' + sourceTypeString, true);
@@ skipping 94 matching lines @@
 
       // Check source type, if needed.
       if (filter.type) {
         var sourceType = this.sourceEntry_.getSourceTypeString().toLowerCase();
         if (filter.type.indexOf(sourceType) == -1)
           return false;
       }
 
       // Check source ID, if needed.
       if (filter.id) {
-        if (filter.id.indexOf(this.sourceEntry_.getSourceId() + '') == -1)
+        if (filter.id.indexOf(this.getSourceId() + '') == -1)
           return false;
       }
 
       if (filter.text == '')
         return true;
 
-      var filterText = filter.text;
-      var entryText = this.sourceEntry_.printAsText().toLowerCase();
+      // The description is not always contained in one of the log entries.
+      if (this.description_.toLowerCase().indexOf(filter.text) != -1)
+        return true;
 
-      return entryText.indexOf(filterText) != -1;
+      var entryText = JSON.stringify(this.sourceEntry_.getLogEntries());

[mmenke, 2011/12/08 21:50:28]

This doesn't work quite as well as the old code, since it doesn't map event
types or network errors to strings.  May think about improving it later.

Could just make a simple TablePrinter function to do this by either blindly
appending everything, not worrying about spaces, or searching all the fields
individually.  Don't like having yet another printing function, but at least it
would be short.

+      return entryText.toLowerCase().indexOf(filter.text) != -1;
     },
 
     isSelected: function() {
       return this.isSelected_;
     },
 
     setSelected: function(isSelected) {
       if (isSelected == this.isSelected())
         return;
 
       this.isSelected_ = isSelected;
 
       this.setSelectedStyles(isSelected);
-      this.parentView_.modifySelectionArray(this, isSelected);
+      this.parentView_.modifySelectionArray(this.getSourceId(), isSelected);
       this.parentView_.onSelectionChanged();
     },
 
     setSelectedStyles: function(isSelected) {
       this.isSelected_ = isSelected;
       this.getSelectionCheckbox().checked = isSelected;
       this.updateClass_();
     },
 
     setMouseoverStyle: function(isMouseOver) {
@@ skipping 21 matching lines @@
     },
 
     onCheckboxToggled_: function() {
       this.setSelected(this.getSelectionCheckbox().checked);
     },
 
     getSelectionCheckbox: function() {
       return this.row_.childNodes[0].firstChild;
     },
 
+    getSourceId: function() {
+      return this.sourceEntry_.getSourceId();
+    },
+
     /**
      * Returns source ID of the entry whose row is currently above this one's.
      * Returns null if no such node exists.
      */
     getPreviousNodeSourceId: function() {
       var prevNode = this.row_.previousSibling;
       if (prevNode == null)
         return null;
       return prevNode._id;
     },
@@ skipping 25 matching lines @@
 
     remove: function() {
       this.setSelected(false);
       this.setIsMatchedByFilter(false);
       this.row_.parentNode.removeChild(this.row_);
     }
   };
 
   return SourceRow;
 })();