Make source_dependencies in about:net-internals clickable.

chrome/browser/resources/net_internals/events_view.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * EventsView displays a filtered list of all events sharing a source, and
  * a details pane for the selected sources.
  *
  *  +----------------------++----------------+
  *  |      filter box      ||                |
@@ skipping 510 matching lines @@
 
     unselectAll_: function() {
       var entries = this.currentSelectedRows_.slice(0);
       for (var i = 0; i < entries.length; ++i) {
         entries[i].setSelected(false);
       }
     },
 
     /**
      * If |params| includes a query, replaces the current filter and unselects.
-     * all items.
+     * all items.  If it includes a selection, tries to select the relevant
+     * item.
      */
     setParameters: function(params) {
       if (params.q) {
         this.unselectAll_();
         this.setFilterText_(params.q);
       }
+
+      if (params.s) {
+        var sourceRow = this.sourceIdToRowMap_[params.s];
+        if (sourceRow)
+          sourceRow.setSelected(true);
+      }
     },
 
     /**
      * If already using the specified sort method, flips direction.  Otherwise,
      * removes pre-existing sort parameter before adding the new one.
      */
     toggleSortMethod_: function(sortMethod) {
       // Remove old sort directives, if any.
       var filterText = this.parseSortDirectives_(this.getFilterText_());
 
@@ skipping 11 matching lines @@
     },
 
     sortBySourceType_: function(event) {
       this.toggleSortMethod_('source');
     },
 
     sortByDescription_: function(event) {
       this.toggleSortMethod_('desc');
     },
 
-    modifySelectionArray: function(sourceRow, addToSelection) {
+    /**
+     * Modifies the map of selected rows to include the on with |sourceId|, if

[eroman, 2011/12/08 22:21:06]

typo: "the one with". also nit: "include/exclude" since it may remove it.

[mmenke, 2011/12/08 22:28:37]

Fixed.

+     * present.  Does not modify checkboxes or the LogView.  Should only be
+     * called by a SourceRow in response to its selection state changing.
+     */
+    modifySelectionArray: function(sourceId, addToSelection) {
+      var sourceRow = this.sourceIdToRowMap_[sourceId];
+      if (!sourceRow)
+        return;
       // Find the index for |sourceEntry| in the current selection list.
       var index = -1;
       for (var i = 0; i < this.currentSelectedRows_.length; ++i) {
         if (this.currentSelectedRows_[i] == sourceRow) {
           index = i;
           break;
         }
       }
 
       if (index != -1 && !addToSelection) {
         // Remove from the selection.
         this.currentSelectedRows_.splice(index, 1);
       }
 
       if (index == -1 && addToSelection) {
         this.currentSelectedRows_.push(sourceRow);
       }
     },
 
     getSelectedSourceEntries_: function() {
       var sourceEntries = [];
-      for (var id in this.currentSelectedRows_) {
-        sourceEntries.push(this.currentSelectedRows_[id].getSourceEntry());
+      for (var i = 0; i < this.currentSelectedRows_.length; ++i) {
+        sourceEntries.push(this.currentSelectedRows_[i].getSourceEntry());
       }
       return sourceEntries;
     },
 
     invalidateDetailsView_: function() {
       this.detailsView_.setData(this.getSelectedSourceEntries_());
     },
 
     invalidateFilterCounter_: function() {
       if (!this.outstandingRepaintFilterCounter_) {
@@ skipping 95 matching lines @@
     var source1Text = source1.getSourceTypeString();
     var source2Text = source2.getSourceTypeString();
     var compareResult = source1Text.localeCompare(source2Text);
     if (compareResult != 0)
       return compareResult;
     return compareSourceId(source1, source2);
   }
 
   return EventsView;
 })();