Make source_dependencies in about:net-internals clickable.

Make source_dependencies in net-internals clickable.

BUG=106777
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113753

[mmenke, 2011-12-08 21:50:24]

I decided to keep it copy+pasteable.  Formatting should be identical to before,
except the [dt=blah] lines are no longer aligned.  I could have kept that, but
decided this approach was simpler.  Also, if we want to switch to pure HTML
formatting, all we need to do from here is add a way to set a table row's
min-width and we're pretty much done.

It might be nice to make clicking on a requested url open it up in a new
"about:cache" tab.  Not sure what else would be worth linking to.  Suppose we
could add links back and forth for the DNS, SPDY, and Sockets, tabs, but not
sure they'd be all that useful.  Sockets tab could really use some better
formatting, but that's another issue entirely...

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/log_view_painter.js:8: *              
the old net-internals is replaced.
I'm thinking in a followup CL, we can move paintLogView and addSourceEntry_ over
to log_view, and rename this file to log_painter or some such.

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/source_row.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/source_row.js:193: var entryText =
JSON.stringify(this.sourceEntry_.getLogEntries());
This doesn't work quite as well as the old code, since it doesn't map event
types or network errors to strings.  May think about improving it later.

Could just make a simple TablePrinter function to do this by either blindly
appending everything, not worrying about spaces, or searching all the fields
individually.  Don't like having yet another printing function, but at least it
would be short.

[eroman, 2011-12-08 22:21:06]

lgtm

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/events_view.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/events_view.js:577: * Modifies the map of
selected rows to include the on with |sourceId|, if
typo: "the one with". also nit: "include/exclude" since it may remove it.

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/log_view_painter.js:114: // Those 6s
skipped cells are: passive annotation, two for "t=", and
is "6s" a typeo? (seems like it should be "6")

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/main.css (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/main.css:93: .event-log a {
i wander if we should prefix the classname by 'events-view-' to reduce chance of
collisions?

.. oh nevermind, i guess the proxy tab uses it too.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/log_view_painter.js:125: return
tablePrinter.toText(0, parent);
I would omit the "return", since toText() shouldn't have any significance to its
return value.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/source_entry.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/source_entry.js:225: return
printLogEntriesAsText(this.entries_, parent);
I would omit the "return", since printLogEntriesAsText() shouldn't have any
significance to its return value.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/table_printer.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/table_printer.js:114: * Returns a
formatted text representation of the table data.
Update this comment -- the return value is no longer significant.

[mmenke, 2011-12-08 22:28:37]

Thanks so much for the review.

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/events_view.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/events_view.js:577: * Modifies the map of
selected rows to include the on with |sourceId|, if
On 2011/12/08 22:21:06, eroman wrote:
> typo: "the one with". also nit: "include/exclude" since it may remove it.

Fixed.

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/8890016/diff/13/chrome/browser/resources/net_i...
chrome/browser/resources/net_internals/log_view_painter.js:114: // Those 6s
skipped cells are: passive annotation, two for "t=", and
On 2011/12/08 22:21:06, eroman wrote:
> is "6s" a typeo? (seems like it should be "6")

Yea, it is.  Fixed.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/log_view_painter.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/log_view_painter.js:125: return
tablePrinter.toText(0, parent);
On 2011/12/08 22:21:06, eroman wrote:
> I would omit the "return", since toText() shouldn't have any significance to
its
> return value.

Done.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/source_entry.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/source_entry.js:225: return
printLogEntriesAsText(this.entries_, parent);
On 2011/12/08 22:21:06, eroman wrote:
> I would omit the "return", since printLogEntriesAsText() shouldn't have any
> significance to its return value.

Done.

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
File chrome/browser/resources/net_internals/table_printer.js (right):

http://codereview.chromium.org/8890016/diff/1030/chrome/browser/resources/net...
chrome/browser/resources/net_internals/table_printer.js:114: * Returns a
formatted text representation of the table data.
On 2011/12/08 22:21:06, eroman wrote:
> Update this comment -- the return value is no longer significant.

Done.

[commit-bot: I haz the power, 2011-12-09 01:57:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8890016/17

[commit-bot: I haz the power, 2011-12-09 02:49:43]

Try job failure for 8890016-17 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-12-09 02:51:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/8890016/17

[commit-bot: I haz the power, 2011-12-09 04:10:19]

Change committed as 113753