Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: runtime/bin/eventhandler_linux.cc

Issue 8890009: Make the write end of the interrupt pipe in the eventhandler blocking on mac and linux. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_linux.cc
diff --git a/runtime/bin/eventhandler_linux.cc b/runtime/bin/eventhandler_linux.cc
index db7a55525a631842e831ef6c71448a706414a5b6..15a57a1757213c314ec4404a32303969cf2bf45a 100644
--- a/runtime/bin/eventhandler_linux.cc
+++ b/runtime/bin/eventhandler_linux.cc
@@ -60,7 +60,6 @@ EventHandlerImplementation::EventHandlerImplementation() {
FATAL("Pipe creation failed");
}
FDUtils::SetNonBlocking(interrupt_fds_[0]);
- FDUtils::SetNonBlocking(interrupt_fds_[1]);
timeout_ = kInfinityTimeout;
timeout_port_ = 0;
}
@@ -106,9 +105,9 @@ void EventHandlerImplementation::WakeupHandler(intptr_t id,
msg.dart_port = dart_port;
msg.data = data;
intptr_t result =
- write(interrupt_fds_[1], &msg, kInterruptMessageSize);
+ FDUtils::WriteToBlocking(interrupt_fds_[1], &msg, kInterruptMessageSize);
if (result != kInterruptMessageSize) {
- perror("Interrupt message failure");
+ FATAL("Interrupt message failure");
}
}
« no previous file with comments | « no previous file | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698