Add preexisting local extensions to sync bundle when sync is enabled.

Add preexisting local extensions to sync bundle when sync is enabled.

BUG=104399
TEST=TwoClientExtensionsSyncTest.UninstallPreinstalledExtensions

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114652

[Yoyo Zhou, 2011-12-14 23:49:48]

I was also looking into adding a test to single_client_extensions_sync_test, but
the obvious thing to do (SetupClients; InstallExtension; SetupSync;
UninstallExtension) doesn't seem to trigger the bug.

[akalin, 2011-12-14 23:52:32]

On 2011/12/14 23:49:48, Yoyo Zhou wrote:
> I was also looking into adding a test to single_client_extensions_sync_test,
but
> the obvious thing to do (SetupClients; InstallExtension; SetupSync;
> UninstallExtension) doesn't seem to trigger the bug.

I'd very much like to have a test that covers this, given that it's breaks basic
functionality and none of our existing tests cover it (apparently).  Even if
it's something like manually checking bundle->synced_extensions after doing a
first-time sync.

[Yoyo Zhou, 2011-12-15 00:54:32]

On 2011/12/14 23:52:32, akalin wrote:
> On 2011/12/14 23:49:48, Yoyo Zhou wrote:
> > I was also looking into adding a test to single_client_extensions_sync_test,
> but
> > the obvious thing to do (SetupClients; InstallExtension; SetupSync;
> > UninstallExtension) doesn't seem to trigger the bug.
> 
> I'd very much like to have a test that covers this, given that it's breaks
basic
> functionality and none of our existing tests cover it (apparently).  Even if
> it's something like manually checking bundle->synced_extensions after doing a
> first-time sync.

Ok, I realized why my test wasn't going to work. I added a new two-client test
that does.

Without this change, in the test, uninstalling the extension from profile 0
fails to get synced over to profile 1. So I think the test is covering this
case.

[akalin, 2011-12-15 00:56:22]

LGTM

thanks for doing this!