Issue 8889047: Fixing bug introduced in r10210 that crashes v8 raytrace benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8889047: Fixing bug introduced in r10210 that crashes v8 raytrace benchmark. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixing bug introduced in r10210 that crashes v8 raytrace benchmark. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10226

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/arm/code-stubs-arm.cc	View		3 chunks	+7 lines, -3 lines	2 comments	Download
	M	test/mjsunit/math-pow.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. http://codereview.chromium.org/8889047/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (left): http://codereview.chromium.org/8889047/diff/1/src/arm/code-stubs-arm.cc#oldcode3524 src/arm/code-stubs-arm.cc:3524: __ vmov(exponent, single_scratch, eq); We try to detect ...

9 years ago (2011-12-09 12:04:37 UTC) #1

LGTM.

Fix ALL the crashes!

Expand Messages | Collapse Messages