chrome/browser/resources/uber/uber.html - Issue 8889041: first cut at uber page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/uber/uber.html

Issue 8889041: first cut at uber page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: total different approach Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html i18n-values="dir:textdirection;">

	3 <head>

	4 <meta charset="utf-8">

	5 <title i18n-content="pageTitle"></title>

	6

	7 <link rel="stylesheet" href="uber.css">

	8

	9 <script src="chrome://uber/uber.js"></script>
	James Hawkins 2011/12/10 03:03:13 I'm not sure we should have a landing page for the I'm not sure we should have a landing page for the uber page, but if we do it's URL is chrome://chrome according to crbug.com/100885. We should structure the code to match, so s/uber/chrome/. Evan Stade 2011/12/10 03:32:32 I'm not sure what you mean that we shouldn't have Show quoted text On 2011/12/10 03:03:13, James Hawkins wrote: > I'm not sure we should have a landing page for the uber page, but if we do it's > URL is chrome://chrome according to crbug.com/100885. We should structure the > code to match, so s/uber/chrome/. I'm not sure what you mean that we shouldn't have a landing page. We need a page that embeds subpages. I really don't like the idea of replacing every instance of "uber" in this cl with "chrome". For example, that would create a class with the mystifying name ChromeUI. The name in the code doesn't have to match the URL. I have no problem changing from "uber" to something that is equally unconfusing.
	10 <script src="chrome://resources/js/command_line.js"></script>

	11 <script src="chrome://resources/js/util.js"></script>

	12 </head>

	13

	14 <body>

	15

	16 <iframe id="settings" src="chrome://settings"></iframe>

	17

	18 </body>

	19 </html>

OLD	NEW