Android emulator image cleanup.

build/android/emulator.py

Index: build/android/emulator.py
diff --git a/build/android/emulator.py b/build/android/emulator.py
index a4b6167f357e9d5201fbbf2284cf2eac84e97bb8..ff65a918d9304f226604123753e29de87b392802 100755
--- a/build/android/emulator.py
+++ b/build/android/emulator.py
@@ -114,6 +114,7 @@ class Emulator(object):
     If fails, an exception will be raised.
     """
     _KillAllEmulators()  # just to be sure
+    self._AggressiveImageCleanup()
     (self.device, port) = self._DeviceName()
     emulator_command = [
         self.emulator,
@@ -135,6 +136,22 @@ class Emulator(object):
     self._InstallKillHandler()
     self._ConfirmLaunch()
 
+  def _AggressiveImageCleanup(self):
+    """Aggressive cleanup of emulator images.
+
+    Experimentally it looks like our current emulator use on the bot
+    leaves image files around in /tmp/android-$USER.  If a "random"
+    name gets reused, we choke with a 'File exists' error.
+    TODO(jrg): is there a less hacky way to accomplish the same goal?
+    """
+    logging.info('Aggressive Image Cleanup')
+    emulator_imagedir = '/tmp/android-%s' % os.environ['USER']
+    for image in os.listdir(emulator_imagedir):

[bulach, 2011/12/09 05:32:26]

nit: you may want to combine with list comprehension..
also, s/fullname/full_name/, and I guess you can use , rather than % on
logging.info..

for full_name in [os.path.join(emulator_imagedir, f)
                  for f in os.listdir(emulator_imagedir)
                  if 'emulator' in f]:
  logging.info('Deleting emualtor image %s', full_name)
  os.unlink(full_name)

+      fullname = os.path.join(emulator_imagedir, image)
+      if 'emulator' in fullname:
+        logging.info('Deleting emulator image %s' % fullname)
+        os.unlink(fullname)
+
   def _ConfirmLaunch(self, wait_for_boot=False):
     """Confirm the emulator launched properly.