Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 8889040: Android emulator image cleanup. (Closed)

Created:
9 years ago by John Grabowski
Modified:
9 years ago
Reviewers:
bulach
CC:
chromium-reviews
Visibility:
Public.

Description

Android emulator image cleanup. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113771

Patch Set 1 #

Patch Set 2 : better #

Total comments: 1

Patch Set 3 : bulach feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/android/emulator.py View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
John Grabowski
9 years ago (2011-12-09 01:46:11 UTC) #1
bulach
LGTM, one suggestion: http://codereview.chromium.org/8889040/diff/3/build/android/emulator.py File build/android/emulator.py (right): http://codereview.chromium.org/8889040/diff/3/build/android/emulator.py#newcode149 build/android/emulator.py:149: for image in os.listdir(emulator_imagedir): nit: you ...
9 years ago (2011-12-09 05:32:26 UTC) #2
John Grabowski
9 years ago (2011-12-09 07:04:14 UTC) #3
Did full_name and printf style string, but I think the list comprehension is
borderline complicated and tough to read at quick glance.  The style guide says
"if simple".  So I'll keep it as is.

Powered by Google App Engine
This is Rietveld 408576698