Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: net/socket/ssl_server_socket_nss.cc

Issue 8889036: Revert 113699 - base::Bind: Convert Socket::Write. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/ssl_server_socket_nss.h ('k') | net/socket/ssl_server_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_server_socket_nss.cc
===================================================================
--- net/socket/ssl_server_socket_nss.cc (revision 113718)
+++ net/socket/ssl_server_socket_nss.cc (working copy)
@@ -66,7 +66,7 @@
transport_recv_busy_(false),
user_handshake_callback_(NULL),
old_user_read_callback_(NULL),
- old_user_write_callback_(NULL),
+ user_write_callback_(NULL),
nss_fd_(NULL),
nss_bufs_(NULL),
transport_socket_(transport_socket),
@@ -199,7 +199,7 @@
int SSLServerSocketNSS::Write(IOBuffer* buf, int buf_len,
OldCompletionCallback* callback) {
- DCHECK(!old_user_write_callback_ && user_write_callback_.is_null());
+ DCHECK(!user_write_callback_);
DCHECK(!user_write_buf_);
DCHECK(nss_bufs_);
@@ -209,25 +209,6 @@
int rv = DoWriteLoop(OK);
if (rv == ERR_IO_PENDING) {
- old_user_write_callback_ = callback;
- } else {
- user_write_buf_ = NULL;
- user_write_buf_len_ = 0;
- }
- return rv;
-}
-int SSLServerSocketNSS::Write(IOBuffer* buf, int buf_len,
- const CompletionCallback& callback) {
- DCHECK(!old_user_write_callback_ && user_write_callback_.is_null());
- DCHECK(!user_write_buf_);
- DCHECK(nss_bufs_);
-
- user_write_buf_ = buf;
- user_write_buf_len_ = buf_len;
-
- int rv = DoWriteLoop(OK);
-
- if (rv == ERR_IO_PENDING) {
user_write_callback_ = callback;
} else {
user_write_buf_ = NULL;
@@ -779,23 +760,15 @@
void SSLServerSocketNSS::DoWriteCallback(int rv) {
DCHECK(rv != ERR_IO_PENDING);
- DCHECK(old_user_write_callback_ || !user_write_callback_.is_null());
+ DCHECK(user_write_callback_);
// Since Run may result in Write being called, clear |user_write_callback_|
// up front.
- if (old_user_write_callback_) {
- OldCompletionCallback* c = old_user_write_callback_;
- old_user_write_callback_ = NULL;
- user_write_buf_ = NULL;
- user_write_buf_len_ = 0;
- c->Run(rv);
- } else {
- CompletionCallback c = user_write_callback_;
- user_write_callback_.Reset();
- user_write_buf_ = NULL;
- user_write_buf_len_ = 0;
- c.Run(rv);
- }
+ OldCompletionCallback* c = user_write_callback_;
+ user_write_callback_ = NULL;
+ user_write_buf_ = NULL;
+ user_write_buf_len_ = 0;
+ c->Run(rv);
}
// static
Property changes on: net/socket/ssl_server_socket_nss.cc
___________________________________________________________________
Deleted: svn:mergeinfo
« no previous file with comments | « net/socket/ssl_server_socket_nss.h ('k') | net/socket/ssl_server_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698