Issue 8889029: Merged in other half of NaCl SDK's r1387 change to update_manifest.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8889029: Merged in other half of NaCl SDK's r1387 change to update_manifest.py (Closed)

Created:
9 years ago by mball

Modified:
9 years ago

Reviewers:
bradnelson, noelallen1, bradn, Matt Ball

CC:
chromium-reviews, pam+watch_chromium.org, der Springer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merged in other half of NaCl SDK's r1387 change to update_manifest.py original CL: Updated update_manifest.py to push manifest files to server http://codereview.chromium.org/8566045 (r1387, not this CL) BUG=None TEST=None TBR=bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113883

Patch Set 1 #

Patch Set 2 : Merge to trunk #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -7 lines)			Patch
M	native_client_sdk/src/build_tools/sdk_tools/sdk_update.py	View		3 chunks	+17 lines, -1 line	0 comments	Download
M	native_client_sdk/src/build_tools/sdk_tools/update_manifest.py	View	1	4 chunks	+48 lines, -6 lines	0 comments	Download
M	native_client_sdk/src/build_tools/tests/update_manifest_test.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mball

I'm still baffled about how the Chromium SDK baseline only used part of r1387 from ...

9 years ago (2011-12-08 21:51:59 UTC) #1

bradn

I'm confused too. I believe I had used a brand new checkout when making the ...

9 years ago (2011-12-09 18:33:32 UTC) #2

Matt Ball

9 years ago (2011-12-09 19:27:58 UTC) #3

I don't know off-hand if these are the only files.  It will take a little
investigation to find out for sure.

Do you still have the svn checkout layout around?  Maybe that will give
some hints.

On Fri, Dec 9, 2011 at 11:33 AM, <bradnelson@google.com> wrote:

> I'm confused too.
> I believe I had used a brand new checkout when making the copy.
> Are these files the only ones that are at the wrong rev?
>
> LGTM
>
>
http://codereview.chromium.**org/8889029/<http://codereview.chromium.org/8889...
>

Expand Messages | Collapse Messages