Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 8889027: GTK: Fix crash on avatar bubble close (Closed)

Created:
9 years ago by sail
Modified:
9 years ago
Reviewers:
Elliot Glaysher, binji
CC:
chromium-reviews
Visibility:
Public.

Description

GTK: Fix crash on avatar bubble close If the avatar bubble closed while opening a profile we would crash. Here's the sequence of events: AvatarMenuBubbleGtk::OpenProfile ->SwitchToProfile(); ... AvatarMenuBubbleGtk::OnDestroy() delete this; this->bubble_->Close(); <--- crash here because this is deleted To prevent these kinds of errors I changed the OnDestory() code to use MessageLoop::DeleteSoon(). This ensures that there no AvatarMenuBubbleGtk functions are in the backtrace when the bubble is deleted. BUG=106640 TEST=Reprorduced the crash. Applied my patch and verified that it no longer crashed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/gtk/avatar_menu_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sail
9 years ago (2011-12-08 21:39:25 UTC) #1
Elliot Glaysher
lgtm
9 years ago (2011-12-08 21:41:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8889027/1
9 years ago (2011-12-08 21:42:32 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-09 00:54:55 UTC) #4
Change committed as 113717

Powered by Google App Engine
This is Rietveld 408576698