Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 8889002: Fix test failures when calling native char conversion functions (e.g wrctomb). (Closed)

Created:
9 years ago by Emmanuel Saint-loubert-Bié
Modified:
9 years ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org, jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix test failures when calling native char conversion functions (e.g wrctomb). This initialization must have been implicit with gtk. On ChromeOS we go down a different code path for these tests. TBR=phajdan.jr@chromium.org BUG=106725 TEST=RTLTest.WrapPathWithLTRFormatting on Aura/Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113614

Patch Set 1 #

Patch Set 2 : changed for linux #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/test/test_suite.cc View 1 chunk +3 lines, -1 line 1 comment Download
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Scott, Please take a look. I think these are the 2 logical places to ...
9 years ago (2011-12-08 02:32:48 UTC) #1
sky
LGTM I'm not an owner of base theough
9 years ago (2011-12-08 05:10:38 UTC) #2
Emmanuel Saint-loubert-Bié
phajdan.jr for OWNERS
9 years ago (2011-12-08 15:59:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8889002/3001
9 years ago (2011-12-08 15:59:24 UTC) #4
commit-bot: I haz the power
Change committed as 113614
9 years ago (2011-12-08 17:32:17 UTC) #5
Paweł Hajdan Jr.
9 years ago (2011-12-09 11:27:55 UTC) #6
http://codereview.chromium.org/8889002/diff/3001/base/test/test_suite.cc
File base/test/test_suite.cc (right):

http://codereview.chromium.org/8889002/diff/3001/base/test/test_suite.cc#newc...
base/test/test_suite.cc:82: setlocale(LC_ALL, "");
Please add comment - why is it here?

Powered by Google App Engine
This is Rietveld 408576698