Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3635)

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_view.h

Issue 8888038: chromeos: Don't fire candidate window open/close events for suggestion window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address yusukes@ comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/candidate_window_view.h
diff --git a/chrome/browser/chromeos/input_method/candidate_window_view.h b/chrome/browser/chromeos/input_method/candidate_window_view.h
index b5570eeb96478997408dbde48e3fa0a4f6bda3ac..2e8adfdb8049d14a4d25da2a8ba558aa6466b55d 100644
--- a/chrome/browser/chromeos/input_method/candidate_window_view.h
+++ b/chrome/browser/chromeos/input_method/candidate_window_view.h
@@ -140,8 +140,14 @@ class CandidateWindowView : public views::View {
// Returns the appropriate area (header or footer) to put auxiliary texts.
InformationTextArea* GetAuxiliaryTextArea();
+ // Returns true if the candidate window is open. The suggestion window does
+ // not count as the candidate window.
bool IsCandidateWindowOpen() const;
+ // Notifies observers if the candidate window's opened/closed state has
+ // changed from the previous call to this function.
+ void NotifyIfCandidateWindowOpenedOrClosed();
+
// The lookup table (candidates).
InputMethodLookupTable lookup_table_;
@@ -192,6 +198,10 @@ class CandidateWindowView : public views::View {
bool is_suggestion_window_location_available_;
+ // True if the candidate window was open. This is used to determine when to
+ // send OnCandidateWindowOpened and OnCandidateWindowClosed events.
+ bool was_candidate_window_open_;
+
DISALLOW_COPY_AND_ASSIGN(CandidateWindowView);
};
« no previous file with comments | « chrome/browser/chromeos/input_method/candidate_window.cc ('k') | chrome/browser/chromeos/input_method/input_method_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698