Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8888037: Windows component build fix for aura. (Closed)

Created:
9 years ago by varunjain
Modified:
9 years ago
Reviewers:
sky, piman
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, tfarina, ben+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Windows component build fix for aura. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113851

Patch Set 1 : patch #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -58 lines) Patch
M ui/aura/client/tooltip_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/aura/root_window.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura_shell/shell_tooltip_manager.cc View 4 chunks +17 lines, -19 lines 0 comments Download
M ui/views/test/test_tooltip_client.cc View 1 1 chunk +0 lines, -28 lines 0 comments Download
M ui/views/views.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
varunjain
9 years ago (2011-12-09 02:30:46 UTC) #1
piman
http://codereview.chromium.org/8888037/diff/2001/ui/views/test/test_tooltip_client.cc File ui/views/test/test_tooltip_client.cc (right): http://codereview.chromium.org/8888037/diff/2001/ui/views/test/test_tooltip_client.cc#newcode1 ui/views/test/test_tooltip_client.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
9 years ago (2011-12-09 02:53:23 UTC) #2
varunjain
http://codereview.chromium.org/8888037/diff/2001/ui/views/test/test_tooltip_client.cc File ui/views/test/test_tooltip_client.cc (right): http://codereview.chromium.org/8888037/diff/2001/ui/views/test/test_tooltip_client.cc#newcode1 ui/views/test/test_tooltip_client.cc:1: // Copyright (c) 2011 The Chromium Authors. All rights ...
9 years ago (2011-12-09 06:43:49 UTC) #3
piman
lgtm
9 years ago (2011-12-09 08:03:21 UTC) #4
sky
LGTM
9 years ago (2011-12-09 17:01:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/8888037/6001
9 years ago (2011-12-09 17:14:01 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-09 22:10:56 UTC) #7 
Change committed as 113851

Powered by Google App Engine
This is Rietveld 408576698