Issue 8888034: Revert 113704 - Remove special casing for firing load completes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8888034: Revert 113704 - Remove special casing for firing load completes. (Closed)

Created:
9 years ago by David Tseng

Modified:
9 years ago

Reviewers:
David Tseng

CC:
chromium-reviews, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, davidbarr+watch_chromium.org, jam, yuzo+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr., ctguil+watch_chromium.org, zork+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 113704 - Remove special casing for firing load completes. With the new logic in SendPendingAccessibilityNotifications, it is no longer necessary to fire a load complete as the first notification to the browser. Since we walk the parent chain, looking for the first entry actually in our browser cache, we will always end up walking up to the root. This change therefore also makes sure that notifications fired on the root will include all of the subtree when composing the notification. BUG=none. TEST=manual. Merge remote-tracking branch 'origin' into build_break Merge branch 'trunk' of http://git.chromium.org/git/chromium into build_break Attempt fixes at chrome frame tests redness. TBR=dtseng Review URL: http://codereview.chromium.org/8869006 TBR=dtseng@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113705

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -12 lines)			Patch
	M	content/browser/accessibility/browser_accessibility_manager.cc	View		4 chunks	+19 lines, -8 lines	0 comments	Download
	M	content/browser/accessibility/browser_accessibility_manager_unittest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages