Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 8888021: Remove MessageLoop::QuitTask() from base. (Closed)

Created:
9 years ago by dcheng
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org, sadrul, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove MessageLoop::QuitTask() from base. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113875

Patch Set 1 #

Patch Set 2 : Sorta fix linux #

Patch Set 3 : *sigh* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -56 lines) Patch
M base/message_loop_proxy_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_pump_glib_unittest.cc View 1 2 17 chunks +60 lines, -54 lines 0 comments Download
M base/observer_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dcheng
Staged cleanup for removing QuitTask entirely.
9 years ago (2011-12-08 19:12:37 UTC) #1
willchan no longer on Chromium
lgtm
9 years ago (2011-12-08 20:22:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8888021/1
9 years ago (2011-12-08 20:23:30 UTC) #3
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-08 22:06:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8888021/1
9 years ago (2011-12-08 22:08:50 UTC) #5
commit-bot: I haz the power
Try job failure for 8888021-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-08 23:07:01 UTC) #6
dcheng
Should I just go ahead and finish the base::Bind() conversion for message_pump_glib_unittest.cc? I got it ...
9 years ago (2011-12-09 00:45:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8888021/4003
9 years ago (2011-12-09 19:55:47 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-09 19:55:54 UTC) #9
Presubmit check for 8888021-4003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
The old callback system is deprecated. If possible, use base::Bind and
base::Callback instead.
    base/message_pump_glib_unittest.cc:216
    base/message_pump_glib_unittest.cc:221
    base/message_pump_glib_unittest.cc:227
    base/message_pump_glib_unittest.cc:231

Presubmit checks took 1.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698