Issue 8888014: Fix Chrome-Skia build on Mac (catch up with http://trac.webkit.org/changeset/102044)

Issue 8888014: Fix Chrome-Skia build on Mac (catch up with http://trac.webkit.org/changeset/102044) (Closed)

Created:
9 years ago by epoger

Modified:
9 years ago

Reviewers:
_cary, caryclark

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix Chrome-Skia build on Mac (catch up with http://trac.webkit.org/changeset/102044) BUG=106842 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113621

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/renderer/print_web_view_helper_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

On 2011/12/08 16:48:45, I haz the power (commit-bot) wrote: > No LGTM from valid reviewers ...

9 years ago (2011-12-14 15:05:40 UTC) #4

epoger

On 2011/12/14 15:05:40, Marc-Antoine Ruel wrote: > On 2011/12/08 16:48:45, I haz the power (commit-bot) ...

9 years ago (2011-12-14 16:33:12 UTC) #5

M-A Ruel

9 years ago (2011-12-19 23:27:45 UTC) #6

On 2011/12/14 16:33:12, epoger wrote:
> On 2011/12/14 15:05:40, Marc-Antoine Ruel wrote:
> > On 2011/12/08 16:48:45, I haz the power (commit-bot) wrote:
> > > No LGTM from valid reviewers yet.
> > 
> > Cary is not a committer yet. But we need to fix the CQ to allow CLs coming
> from
> > a reviewer to be reviewed by a non-committer (albeit with a warning message)
> 
> I don't know if it matters, M-A, but I have re-read that last sentence 3 times
> and I still don't understand it.  Who's on first?

Right now, even if you are a full committer, you need a lgtm from another full
committer. A provisional committer won't do. That's something I want to fix.

Expand Messages | Collapse Messages