Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: test/mjsunit/array-concat.js

Issue 8888006: Make more JS files beter match the coding standard. Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/array-concat.js
diff --git a/test/mjsunit/array-concat.js b/test/mjsunit/array-concat.js
index 97bd85aca2e646cd391558e0648458575d4e3c8b..f7f77b01aac60430a38194de68d3708a763a379d 100644
--- a/test/mjsunit/array-concat.js
+++ b/test/mjsunit/array-concat.js
@@ -183,7 +183,7 @@ assertEquals("Hello", c[0]);
assertEquals("Hello", c.toString());
// Check that concat preserves holes.
-var holey = [void 0,'a',,'c'].concat(['d',,'f',[0,,2],void 0])
+var holey = [void 0,'a',,'c'].concat(['d',,'f',[0,,2],void 0]);
assertEquals(9, holey.length); // hole in embedded array is ignored
for (var i = 0; i < holey.length; i++) {
if (i == 2 || i == 5) {
@@ -206,7 +206,7 @@ assertEquals([,2,1,3], r1);
Object.defineProperty(arr1, 0, {get: function() {
arr2.push("X");
Rico 2011/12/08 10:24:37 indention (I don't think 4 indent + 2 for the func
return undefined;
- }, configurable: true})
+ }, configurable: true});
var r2 = [].concat(arr1, arr2); // [undefined,2,1,3,"X"]
assertEquals([undefined,2,1,3,"X"], r2);
@@ -215,7 +215,7 @@ arr2.length = 2;
Object.defineProperty(arr1, 0, {get: function() {
arr2[500000] = "X";
Rico 2011/12/08 10:24:37 indention
return undefined;
- }, configurable: true})
+ }, configurable: true});
var r3 = [].concat(arr1, arr2); // [undefined,2,1,3,"X"]
var expected = [undefined,2,1,3];
expected[500000 + 2] = "X";
@@ -224,7 +224,7 @@ assertEquals(expected, r3);
var arr3 = [];
var trace = [];
-var expectedTrace = []
+var expectedTrace = [];
function mkGetter(i) { return function() { trace.push(i); }; }
Rico 2011/12/08 10:24:37 remove last semicolon
Lasse Reichstein 2011/12/08 12:33:18 No, it ends the return statement.
arr3.length = 10000;
for (var i = 0; i < 100; i++) {

Powered by Google App Engine
This is Rietveld 408576698