Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: test/mjsunit/compiler/null-compare.js

Issue 8888006: Make more JS files beter match the coding standard. Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 function IsNull(x) { 28 function IsNull(x) {
29 if (x == null) return true; else return false; 29 if (x == null) { return true;
Rico 2011/12/08 10:24:37 this did not get much better :-)
30 } else return false;
30 } 31 }
31 32
32 assertTrue(IsNull(null), "null == null"); 33 assertTrue(IsNull(null), "null == null");
33 assertTrue(IsNull(void 0), "void 0 == null"); 34 assertTrue(IsNull(void 0), "void 0 == null");
34 assertFalse(IsNull(42), "42 != null"); 35 assertFalse(IsNull(42), "42 != null");
35 36
36 37
37 function IsNullStrict(x) { 38 function IsNullStrict(x) {
38 if (x === null) return true; else return false; 39 if (x === null) { return true;
Rico 2011/12/08 10:24:37 neither did this
40 } else return false;
39 } 41 }
40 42
41 assertTrue(IsNullStrict(null), "null === null"); 43 assertTrue(IsNullStrict(null), "null === null");
42 assertFalse(IsNullStrict(void 0), "void 0 != null"); 44 assertFalse(IsNullStrict(void 0), "void 0 != null");
43 assertFalse(IsNullStrict(87), "87 !== null"); 45 assertFalse(IsNullStrict(87), "87 !== null");
44 46
45 47
46 function GimmeFalse(x) { 48 function GimmeFalse(x) {
47 if ((x & 1) == null) return true; 49 if ((x & 1) == null) return true;
48 if ((x | 3) === null) return true; 50 if ((x | 3) === null) return true;
49 return false; 51 return false;
50 } 52 }
51 53
52 assertFalse(GimmeFalse(1), "GimmeFalse(1)"); 54 assertFalse(GimmeFalse(1), "GimmeFalse(1)");
53 assertFalse(GimmeFalse(null), "GimmeFalse(null)"); 55 assertFalse(GimmeFalse(null), "GimmeFalse(null)");
54 assertFalse(GimmeFalse({}), "GimmeFalse({})"); 56 assertFalse(GimmeFalse({}), "GimmeFalse({})");
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698