Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 8887003: Add support for high contrast mode to bubbles (Closed)

Created:
9 years ago by sail
Modified:
9 years ago
Reviewers:
msw, sky
CC:
chromium-reviews, msw+watch_chromium.org, alicet1, tfarina
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix linux aura build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sail
sky: ui/views, browser/ui/views OWNERS review
9 years ago (2011-12-08 02:43:06 UTC) #1
msw
LGTM with question/nit. http://codereview.chromium.org/8887003/diff/1/chrome/browser/ui/views/avatar_menu_bubble_view.cc File chrome/browser/ui/views/avatar_menu_bubble_view.cc (right): http://codereview.chromium.org/8887003/diff/1/chrome/browser/ui/views/avatar_menu_bubble_view.cc#newcode293 chrome/browser/ui/views/avatar_menu_bubble_view.cc:293: name_label_->SetBackgroundColor(background_color); Labels should find backgrounds up ...
9 years ago (2011-12-08 05:46:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8887003/1
9 years ago (2011-12-08 05:52:01 UTC) #3
commit-bot: I haz the power
Presubmit check for 8887003-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years ago (2011-12-08 05:52:04 UTC) #4
sail
http://codereview.chromium.org/8887003/diff/1/ui/views/bubble/bubble_delegate.cc File ui/views/bubble/bubble_delegate.cc (right): http://codereview.chromium.org/8887003/diff/1/ui/views/bubble/bubble_delegate.cc#newcode75 ui/views/bubble/bubble_delegate.cc:75: #if defined(OS_WIN) && !defined(USE_AURA) On 2011/12/08 05:46:30, msw wrote: ...
9 years ago (2011-12-08 05:52:07 UTC) #5
msw
Fair enough (although I think it would probably just work on Aura). LGTM. Please note ...
9 years ago (2011-12-08 06:35:28 UTC) #6
sky
LGTM
9 years ago (2011-12-08 17:08:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/8887003/1
9 years ago (2011-12-08 17:47:35 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-08 18:56:44 UTC) #9
Change committed as 113634

Powered by Google App Engine
This is Rietveld 408576698