Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 8887002: aura/cc: fix interactive_ui_tests (Closed)

Created:
9 years ago by piman
Modified:
9 years ago
Reviewers:
oshima, sky
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

aura/cc: fix interactive_ui_tests BUG=106787 TEST=interactive_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113632

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 3 chunks +13 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
piman
9 years ago (2011-12-08 02:13:33 UTC) #1
piman
9 years ago (2011-12-08 03:52:45 UTC) #2
sky
http://codereview.chromium.org/8887002/diff/1/chrome/test/base/view_event_test_base.cc File chrome/test/base/view_event_test_base.cc (right): http://codereview.chromium.org/8887002/diff/1/chrome/test/base/view_event_test_base.cc#newcode89 chrome/test/base/view_event_test_base.cc:89: ui::CompositorTestSupport::Initialize(); Should this be ifdef'd around VIEWS_COMPOSITOR?
9 years ago (2011-12-08 04:34:43 UTC) #3
piman
http://codereview.chromium.org/8887002/diff/1/chrome/test/base/view_event_test_base.cc File chrome/test/base/view_event_test_base.cc (right): http://codereview.chromium.org/8887002/diff/1/chrome/test/base/view_event_test_base.cc#newcode89 chrome/test/base/view_event_test_base.cc:89: ui::CompositorTestSupport::Initialize(); On 2011/12/08 04:34:44, sky wrote: > Should this ...
9 years ago (2011-12-08 07:10:18 UTC) #4
sky
Looks like it passed bots, so LGTM
9 years ago (2011-12-08 17:13:18 UTC) #5
oshima
LGTM thank you for prompt fix!
9 years ago (2011-12-08 17:31:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8887002/1
9 years ago (2011-12-08 17:31:30 UTC) #7
commit-bot: I haz the power
9 years ago (2011-12-08 18:54:27 UTC) #8
Change committed as 113632

Powered by Google App Engine
This is Rietveld 408576698